Page MenuHomePhabricator
Create Task
Maniphest T316552

Tests: Add proper FE integration tests for most important use case(s)
Closed, ResolvedPublic
Actions

Description

We don't have any integration tests.

This task is to start working out our best approach to have some, and it includes:

  • Figuring out a use case that we should cover (as normal user flow, part of function editor)
  • Implement the integration test

Related Objects
Search...

Event Timeline

gengh created this task.Aug 29 2022, 2:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2022, 2:52 PM
gengh assigned this task to Ddwaal.Aug 29 2022, 2:52 PM
EWright subscribed.Aug 30 2022, 10:39 AM
EWright added a comment.Aug 30 2022, 12:30 PM

I'm going to work with Dani on this.

EWright renamed this task from Tests: Add proper integration tests to Function Editor to Tests: Add proper integration tests for most important use case(s).Aug 30 2022, 2:34 PM
EWright added a project: Epic.
AAlhazwani-WMF subscribed.EditedSep 12 2022, 5:07 PM

The selected uses cases are (ordered by priority):

  1. Evaluate a function (aka function call), top-right box in the function viewer (inside the about tab)
    1. This is currently blocked by design and respective front-end work that still needs to happen. Updates on this will be published to T317556: Design and implement: evaluate a function.
  2. Create a function
  3. Edit a function (editing labels and languages)
  4. Create tests
  5. Add implementations (via code or composition)
  6. Connect an implementation or test to a function
  7. Types creation and/or editing

cc @Ddwaal-WMF @EWright-WMF

gengh mentioned this in T316669: Tests: Implement FE integration test for creating a new function.Sep 13 2022, 3:45 PM
EWright renamed this task from Tests: Add proper integration tests for most important use case(s) to Tests: Add proper FE integration tests for most important use case(s).Sep 23 2022, 1:13 PM
EWright changed the status of subtask T318416: Tests: Implement Function Evaluator widget integration test for evaluating a function from Open to Stalled.Sep 23 2022, 1:15 PM
EWright changed the status of subtask T318427: Tests: Implement FE integration test for creating a new type from Open to Stalled.Sep 23 2022, 2:26 PM
gengh closed subtask T316669: Tests: Implement FE integration test for creating a new function as Resolved.Oct 4 2022, 4:51 PM
gengh removed Ddwaal as the assignee of this task.Oct 5 2022, 12:24 PM
gengh added a subscriber: Ddwaal.
gengh closed subtask T318413: Tests: Implement FE integration test for editing a function as Resolved.Oct 6 2022, 11:27 AM
gengh closed subtask T318426: Tests: Implement FE integration test for connecting implementations and testers to functions as Resolved.Oct 11 2022, 2:51 PM
gengh closed subtask T316668: Tests: Describe use case(s) to be covered by integration tests as Resolved.Oct 11 2022, 2:53 PM
gengh reopened subtask T318426: Tests: Implement FE integration test for connecting implementations and testers to functions as Open.Oct 11 2022, 3:40 PM
EWright closed subtask T316667: Tests: Evaluate best framework to use for integration tests as Resolved.Oct 13 2022, 12:40 PM
AAlhazwani-WMF unsubscribed.Oct 26 2022, 12:36 PM
gengh closed subtask T318426: Tests: Implement FE integration test for connecting implementations and testers to functions as Resolved.Nov 8 2022, 3:57 PM
EWright changed the status of subtask T318416: Tests: Implement Function Evaluator widget integration test for evaluating a function from Stalled to Open.Dec 19 2022, 3:09 PM
DVrandecic moved this task from Ready: G4. Function view to Ready: G9. Cleanup after default component implementation on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 5 2023, 7:41 PM
DVrandecic closed subtask T318421: Tests: Implement FE integration test for creating a new implementation via code as Resolved.Jan 17 2023, 9:07 PM
DVrandecic closed subtask T318425: Tests: Implement FE integration test for creating a new implementation via composition as Resolved.
DVrandecic closed subtask T318420: Tests: Implement FE integration test for creating a new tester as Resolved.
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 8:58 AM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (Phase λ – Launch); removed: Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 9:38 AM
Jdforrester-WMF removed a subtask: T317782: Document: Create wiki page with guidelines about Jest and frontend integration tests.Jun 20 2023, 12:53 PM
Jdforrester-WMF triaged this task as Medium priority.Jul 19 2023, 3:06 PM
DVrandecic changed the task status from Open to In Progress.Jul 22 2023, 2:12 AM
DVrandecic moved this task from Engineering tasks to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.
Jdforrester-WMF moved this task from In progress to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 24 2023, 8:53 PM
gengh moved this task from Engineering tasks to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 26 2023, 8:43 AM
Jdforrester-WMF moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 26 2023, 11:21 PM
DVrandecic closed subtask T318416: Tests: Implement Function Evaluator widget integration test for evaluating a function as Resolved.Jul 27 2023, 2:30 AM
DVrandecic closed this task as Resolved.Jul 27 2023, 2:33 AM
DVrandecic claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits