Page MenuHomePhabricator
Create Task
Maniphest T316567

Check if results are ready before showing info-icons for tester runs
Closed, ResolvedPublic
Actions

Description

consider disabling the dialog if the results aren't back and/or having some "RESULTS NOT READY" message in the dialog...right now we just get the header and nothing else.

2022-11-21: the instances of the metadata dialog in question are created in ZTesterImplResult.vue and TesterTableStatus.vue, after a click on the "info icon" for a tester run. A better way to solve this problem is to arrange for these info icons to appear *after* the results have returned from the tester runs. Renaming the ticket to reflect this.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikiLambdamaster+2 -2Check if results are ready before showing info-icons for tester runs
Customize query in gerrit

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Aug 29 2022, 4:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2022, 4:44 PM
DMartin-WMF claimed this task.Aug 29 2022, 4:44 PM
DMartin-WMF moved this task from Incoming to Ready: G3. Meta-data about calls on the Abstract Wikipedia team (Phase θ – Throttling) board.
DMartin-WMF added a project: Abstract Wikipedia Fix-It tasks.Sep 21 2022, 1:08 AM
DMartin-WMF removed DMartin-WMF as the assignee of this task.Oct 3 2022, 7:27 PM
Jdforrester-WMF added a parent task: T303345: Function, Implementation, and Tester meta-data is emitted and displayed to users.Oct 5 2022, 7:23 PM
DMartin-WMF renamed this task from Check if results are ready before showing metadata dialog to Check if results are ready before showing info-icons for metadata dialog instances.Nov 22 2022, 5:59 AM
DMartin-WMF updated the task description. (Show Details)
DMartin-WMF renamed this task from Check if results are ready before showing info-icons for metadata dialog instances to Check if results are ready before showing info-icons for tester runs.Nov 22 2022, 6:04 AM
gerritbot added a comment.Nov 22 2022, 6:05 AM

Change 859169 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Check if results are ready before showing info-icons for tester runs

https://gerrit.wikimedia.org/r/859169

gerritbot added a project: Patch-For-Review.Nov 22 2022, 6:05 AM
DMartin-WMF claimed this task.Nov 22 2022, 6:58 PM
gerritbot added a comment.Nov 28 2022, 4:45 PM

Change 859169 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Check if results are ready before showing info-icons for tester runs

https://gerrit.wikimedia.org/r/859169

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 28 2022, 5:01 PM
DMartin-WMF closed this task as Resolved.Nov 28 2022, 5:28 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 28 2022, 5:31 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL