Maniphest T316571

[Technical] Add Jest tests for TOC before/after edit
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 29 2022, 5:03 PM

Tags

Referenced Files

None

Subscribers

Description

In T307251 a new workflow was added to update the table of contents after an edit. Tests are an important part of this feature, as it will seldom be used during manual testing so we should strive to have test coverage for the feature.

Acceptance criteria

Add Jest unit tests for all functions added in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/802676/8/resources/skins.vector.es6/tableOfContents.js
Update the test coverage threshold

Details

	Subject	Repo	Branch	Lines +/-
	Add Jest tests for TOC before/after edit	mediawiki/skins/Vector	master	+265 -46
	Remove unreachable code in tableOfContents.js	mediawiki/skins/Vector	master	+2 -20

Customize query in gerrit

Related Objects

Mentioned In: T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC)
Mentioned Here: T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC)

Event Timeline

Jdlrobson created this task.Aug 29 2022, 5:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2022, 5:03 PM

Jdlrobson triaged this task as High priority.Aug 29 2022, 5:03 PM

Jdlrobson mentioned this in T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC).

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 29 2022, 5:11 PM

LGoto set the point value for this task to 3.Aug 30 2022, 5:34 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

• nray claimed this task.Sep 6 2022, 4:20 PM

• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Jdlrobson lowered the priority of this task from High to Low.Sep 6 2022, 5:27 PM

@nray Please add me in the loop for this task I want to learn the jest unit testing and how we do it

@Mabualruz No worries, I'll let you know when I'm deep into the jest stuff!

Change 831636 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Remove unreachable code in tableOfContents.js

https://gerrit.wikimedia.org/r/831636

gerritbot added a project: Patch-For-Review.Sep 12 2022, 11:52 PM

Change 832283 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Add Jest tests for TOC before/after edit

https://gerrit.wikimedia.org/r/832283

• nray removed • nray as the assignee of this task.Sep 14 2022, 3:46 PM

• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

• nray subscribed.

• nray moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 14 2022, 3:59 PM

• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 14 2022, 4:25 PM

Jdlrobson assigned this task to Mabualruz.Sep 14 2022, 4:48 PM

Change 831636 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove unreachable code in tableOfContents.js

https://gerrit.wikimedia.org/r/831636

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 19 2022, 5:00 PM

Mabualruz reassigned this task from Mabualruz to Edtadros.Sep 19 2022, 6:15 PM

Mabualruz moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Since this work only added tests/removed code that wasn't being used, I'm assuming it can skip qa

• nray removed Edtadros as the assignee of this task.Sep 19 2022, 6:41 PM

• nray added a subscriber: Edtadros.

Jdlrobson updated the task description. (Show Details)Sep 19 2022, 10:10 PM

Moving back because https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/832283 failed to merge (jest coverage threshold needed to be adjusted)

• nray moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 19 2022, 11:15 PM

Change 832283 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add Jest tests for TOC before/after edit

https://gerrit.wikimedia.org/r/832283

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2022, 11:30 PM

LGoto assigned this task to Jdrewniak.Sep 20 2022, 5:40 PM

Jdrewniak closed this task as Resolved.Sep 21 2022, 3:45 PM