Page MenuHomePhabricator

[regression] [Visual refinements] Toolbar tabs should not get :visited styling
Closed, ResolvedPublic0 Estimated Story Points

Description

Description

Currently in Vector 2022 on MediaWiki (and maybe others) the tabs in the toolbar get :visited styling if you visit them. This is not the case in Legacy Vector, and should not be the case in Vector 2022.

Screen Shot 2022-08-26 at 11.20.19 AM.png (692×860 px, 105 KB)
Screen Shot 2022-08-26 at 11.19.15 AM.png (1×2 px, 745 KB)

To-do

  • Toolbar tabs should not get :visited styling (even when they have been visited)

QA Results - Beta

ACStatusDetails
1T316574#8216104

QA Results - Prod

ACStatusDetails
1T316574#8230611

Event Timeline

Jdlrobson added a project: Regression.

Legacy Vector explicitly defines a link color in .vector-menu-tabs-legacy li a { color: @color-link; } which is more specific than the generic a:visited link.
This is a regression caused by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/815323 (Bug: T308344). Can therefore skip estimation.

Jdlrobson renamed this task from [Visual refinements] Toolbar tabs should not get :visited styling to [regression] [Visual refinements] Toolbar tabs should not get :visited styling.Aug 29 2022, 5:55 PM
Jdlrobson set the point value for this task to 0.

Change 828582 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Override visited link style in MenuTabs

https://gerrit.wikimedia.org/r/828582

Change 828582 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Override visited link style in MenuTabs

https://gerrit.wikimedia.org/r/828582

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Toolbar tabs should not get visited styling (even when they've been visited)

Screen Recording 2022-09-06 at 2.25.42 PM.mov.gif (354×1 px, 871 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: dewiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Toolbar tabs should not get visited styling (even when they've been visited)

Screen Recording 2022-09-12 at 1.58.09 PM.mov.gif (316×1 px, 1 MB)

Looks good! Resolving