Page MenuHomePhabricator
Create Task
Maniphest T316609

Buttons in sticky header should never wrap
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
• alexhollender_WMF
Aug 29 2022, 10:48 PM
Tags
Referenced Files
F35535557: Screen Shot 2022-09-26 at 3.43.54 PM.png
Sep 26 2022, 10:44 PM
F35535556: Screen Shot 2022-09-26 at 3.44.01 PM.png
Sep 26 2022, 10:44 PM
F35535552: Screen Shot 2022-09-26 at 3.42.37 PM.png
Sep 26 2022, 10:44 PM
F35527737: Screen Shot 2022-09-21 at 7.24.43 PM.png
Sep 22 2022, 2:25 AM
F35501581: Screen Shot 2022-08-31 at 9.59.10 AM.png
Aug 31 2022, 5:00 PM
F35488036: image.png
Aug 29 2022, 10:48 PM
F35488035: image.png
Aug 29 2022, 10:48 PM
Subscribers
Aklapper
• alexhollender_WMF
bwang
Edtadros
Jdlrobson
ovasileva

Description

Description

After T311103 the language button and/or "Add topic" button are wrapping if the page has a long title:

example article

currentexpected/correct
image.png (1×2 px, 588 KB)
image.png (1×2 px, 587 KB)

QA

Expected;
No wrapping

Actual:

Screen Shot 2022-08-31 at 9.59.10 AM.png (626×2 px, 859 KB)

To-do

  • Ensure the language button never wraps in the sticky header

Developer notes

Add white-space: nowrap; to #p-lang-btn-sticky-header

QA Results - Beta

ACStatusDetails
1✅T316609#8252242

QA Results - Prod

ACStatusDetails
1✅T316609#8262731

Details

SubjectRepoBranchLines +/-
Update collapsed TOC menu widthmediawiki/skins/Vectormaster+42 -17
Prevent language button in sticky header from word breakingmediawiki/skins/Vectormaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Aug 29 2022, 10:48 PM
• alexhollender_WMF mentioned this in T311103: Make collapsed ToC available in sticky header.
Jdlrobson moved this task from Incoming to A11Y on the Desktop Improvements (Vector 2022) board.Aug 29 2022, 11:59 PM
Jdlrobson moved this task from A11Y to Language Switching on the Desktop Improvements (Vector 2022) board.
ovasileva triaged this task as Medium priority.Aug 30 2022, 9:12 AM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-2022-23-Q1).Aug 30 2022, 5:14 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.Aug 31 2022, 2:41 PM

Discussed with Alex and this one would be a potential blocker or a nice-to-have at least

ovasileva added a parent task: T301780: [Epic] Visual design & layout refinements.Aug 31 2022, 2:42 PM
Jdlrobson added a comment.EditedAug 31 2022, 4:43 PM

@alexhollender_WMF : can you change the privacy on the images?

Jdlrobson updated the task description. (Show Details)Aug 31 2022, 5:00 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
• alexhollender_WMF added a comment.Sep 1 2022, 7:13 PM
In T316609#8203271, @Jdlrobson wrote:

@alexhollender_WMF : can you change the privacy on the images?

sorry, fixed

Jdlrobson mentioned this in T301780: [Epic] Visual design & layout refinements.Sep 12 2022, 7:15 PM
ovasileva edited parent tasks, added: T317632: [EPIC] Visual refinements pt2; removed: T301780: [Epic] Visual design & layout refinements.Sep 13 2022, 12:37 PM
LGoto set the point value for this task to 2.Sep 13 2022, 5:29 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
bwang moved this task from Ready for Development to Design Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 15 2022, 3:09 PM
bwang moved this task from Design Review to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson added a comment.Sep 15 2022, 3:48 PM

@bwang I'm not seeing a patch on this one. Feel free to add me to it when it's ready for review.

gerritbot added a comment.Sep 15 2022, 4:21 PM

Change 832516 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Prevent language button in sticky header from work breaking

https://gerrit.wikimedia.org/r/832516

gerritbot added a project: Patch-For-Review.Sep 15 2022, 4:21 PM
Jdlrobson assigned this task to Edtadros.Sep 15 2022, 4:29 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
gerritbot added a comment.Sep 15 2022, 4:45 PM

Change 832516 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Prevent language button in sticky header from word breaking

https://gerrit.wikimedia.org/r/832516

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 15 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2022, 5:30 PM
gerritbot added a comment.Sep 15 2022, 5:37 PM

Change 831126 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Update collapsed TOC menu width

https://gerrit.wikimedia.org/r/831126

gerritbot added a project: Patch-For-Review.Sep 15 2022, 5:37 PM
bwang renamed this task from Language button should never wrap in sticky header to Buttons in sticky header should never wrap.Sep 15 2022, 5:49 PM
bwang updated the task description. (Show Details)
gerritbot added a comment.Sep 15 2022, 5:58 PM

Change 831126 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update collapsed TOC menu width

https://gerrit.wikimedia.org/r/831126

gerritbot added a comment.Sep 15 2022, 7:51 PM

Change 832551 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.1] Update collapsed TOC menu width

https://gerrit.wikimedia.org/r/832551

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 22 2022, 2:25 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a page with multiple languages
Resize browser to 1019px
Scrolldown
AC1: Language should not wrap in sticky header.

Screen Shot 2022-09-21 at 7.24.43 PM.png (214×1 px, 86 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Sep 26 2022, 10:44 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: dewiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a page with multiple languages
Resize browser to 1019px
Scrolldown
AC1: Language should not wrap in sticky header.

Screen Shot 2022-09-26 at 3.42.37 PM.png (573×1 px, 269 KB)

Screen Shot 2022-09-26 at 3.44.01 PM.png (330×1 px, 98 KB)

Screen Shot 2022-09-26 at 3.43.54 PM.png (393×1 px, 299 KB)

Edtadros updated the task description. (Show Details)Sep 26 2022, 10:46 PM
ovasileva closed this task as Resolved.Sep 27 2022, 10:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL