Page MenuHomePhabricator

Image suggestions: add instrumentation for "No suggestion found"
Closed, ResolvedPublic


We log messages to Logstash for various errors around image suggestion workflow failures (for example: T313973: GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::get Unable to decode JSON response for page {title} upstream connect error or disconnect/reset before headers. reset reason: connection termination). But we don't emit events to Grafana, so that we can plot volume over time, like we do for AddLink.

Acceptance Criteria

  1. Visit the Special:Homepage grafana dashboard and see a panel showing "No suggestion found" errors for AddImage


Completion checklist


  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria


  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.


  • Related and updated documentation done where necessary

Event Timeline

kostajh added subscribers: KStoller-WMF, DMburugu.

cc @KStoller-WMF @DMburugu. I think we should prioritize doing this, so we have better insight into how many users are experiencing errors as part of the add image workflow. I think we can pull this data from our analytics data, but it would be more convenient to have it on our Grafana dashboard alongside other metrics.

That makes sense to me, and I assume it's fairly quick work to instrument this (please let me know if I'm wrong).
I'm curious to know if we'll start to see more of these errors now that the structured data team has launched image suggestions for experienced users.

Change 882270 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Log to statsd when a suggested editing task is not available

Change 882270 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Log to statsd when a suggested editing task is not available