Page MenuHomePhabricator
Create Task
Maniphest T316869

VE doesn't re-open when pressing browser-forward on SET wikis
Closed, ResolvedPublic
Actions

Description

In T316771#8205034, @matmarex wrote:

While testing the fix, I noticed that using browser forward (or back) to re-enter the editor after leaving it is also not working (in single edit tab mode).

  1. Open a SET wiki, e.g. https://ca.wikipedia.beta.wmflabs.org/wiki/Test
  2. Press edit
  3. Press browser back (the editor closes)
  4. Press browser forward

Observed

  1. Nothing happens

Expected

  1. The editor re-opens

Details

SubjectRepoBranchLines +/-
DesktopArticleTarget: Fix popstate handling when action=edit (single edit tab)mediawiki/extensions/VisualEditormaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 1 2022, 1:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2022, 1:55 PM
gerritbot added a comment.Sep 1 2022, 1:56 PM

Change 829008 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Fix popstate handling when action=edit (single edit tab)

https://gerrit.wikimedia.org/r/829008

gerritbot added a project: Patch-For-Review.Sep 1 2022, 1:56 PM
Esanders edited projects, added Editing-team (Kanban Board); removed Patch-For-Review.Sep 1 2022, 3:56 PM
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
Esanders moved this task from To Triage to Triaged on the VisualEditor board.
Esanders mentioned this in T316771: URL in address bar is wrong after pressing back from section edit link.
gerritbot added a comment.Sep 1 2022, 8:18 PM

Change 829008 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Fix popstate handling when action=edit (single edit tab)

https://gerrit.wikimedia.org/r/829008

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Sep 1 2022, 9:00 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 1 2022, 10:25 PM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Sep 7 2022, 6:55 AM
EAkinloose subscribed.

✅ The Editor re-opens. See https://photos.app.goo.gl/hsVWZ7jkoLGuWrqa9
Before fix, it looked like https://photos.app.goo.gl/5EC9G6tbmVuaf5kb6

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 7 2022, 6:55 AM
ppelberg closed this task as Resolved.Sep 22 2022, 4:50 PM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits