Page MenuHomePhabricator

Add pfischer to #wmf-nda on Phab and to #wmf on LDAP
Closed, ResolvedPublic

Description

Hi! I started working as engineer for search platform in September. Creating this ticket is part of my onboarding todos.

@pfischer will need to access NDA tasks on Phabricator to be able to follow and fix security issues on the Search Platform projects.

@pfischer will need to be a member of the #wmf LDAP group for access to logstash, turnilo, grafana, etc...

Phabricator account: pfischer
Shell username: pfischer
SSH Public Key: ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIH+qwSlb7Cz54C93i61yk5rwx5hyqaofOdJw/TkRVVCZ pfischer@wikimedia.org

Event Timeline

Hi @pfischer, thanks for taking the time to report this! Is this about the LDAP group, or about the Phabricator project tag? If the latter, then it should be part of the process for the former anyway, and not require filing a separate ticket anymore. (Is the onboarding checklist of your team available somewhere?)

@Aklapper : our onboarding doc might be outdated on this. It is referencing getting access to the NDA group in Phab, but @pfischer is also going to need to be added to the LDAP wmf group (for access to logstash, grafana, turnilo, etc...). If those 2 requests can be merged into a single one, then great! I'll update the description.

For the record, the doc about getting LDAP wmf access seems to be at https://wikitech.wikimedia.org/wiki/SRE/LDAP/Groups.

Gehel renamed this task from Add pfischer to #wmf-nda to Add pfischer to #wmf-nda on Phab and to #wmf on LDAP.Sep 2 2022, 2:33 PM
Gehel added a project: LDAP-Access-Requests.
Gehel updated the task description. (Show Details)

fwiw WMF-NDA on Phabricator and LDAP groups are entirely unrelated things and handled by different people. (not saying it can't be handled in one ticket, we just need to pass it along, no biggie). Just to make clear there is no relation between them.

@pfischer I'm the clinic duty person this week.
Can you confirm your wikimedia email address, please, and that you set up a wikimedia developer account[0], please?

I ran the usual check script[1] against pfischer@ and it didn't find a wikitech account (nor a job title or manager)...

[0] cf https://wikitech.wikimedia.org/wiki/Help:Create_a_Wikimedia_developer_account
[1] https://wikitech.wikimedia.org/wiki/SRE/Clinic_Duty/Access_requests#Verifying_WMF_developer_accounts

@MatthewVernon, thank you, for looking into this. I already created a dev account, please have look at the attached screenshot

wmf_dev_account_pfischer.png (772×840 px, 230 KB)
.

Update: Unfortunately, even though @pfischer has created the Wikitech dev account, nothing has changed since @MatthewVernon 's comment above:

sudo check_user [redacted for spam prevention]
WikiTech Users:
	no user found with [redacted for spam prevention]

Gsuit User:
	Primary Email:	[redacted for spam prevention]
	Aliases:
	title:		No title found.
	manager:	No manager found.
	agreedToTerms:	True

I'm not sure if it takes awhile to sync this information. I will reach out to IT in Slack to see if they have any ideas on the Gsuite side of things.

@pfischer Can you add your SSH public key to this ticket so I can add you to shell users?

@Gehel Should Peter have access to all groups that EBernhardson and dcausse are in? If not, please specify which groups he needs to be in.

Update: Unfortunately, even though @pfischer has created the Wikitech dev account, nothing has changed since @MatthewVernon 's comment above:

sudo check_user [redacted for spam prevention]
WikiTech Users:
	no user found with [redacted for spam prevention]

Gsuit User:
	Primary Email:	[redacted for spam prevention]
	Aliases:
	title:		No title found.
	manager:	No manager found.
	agreedToTerms:	True

I'm not sure if it takes awhile to sync this information. I will reach out to IT in Slack to see if they have any ideas on the Gsuite side of things.

Not sure if this is why, but I did find this:

Note that is possible that a developer account exists without a corresponding Wikitech account, if the user signed up for the account using the Toolforge admin console and has not logged into Wikitech.

@pfischer Per the above, you might need to log into Wikitech directly. Want to give that a try when you get a chance and then we'll see if you appear in WikiTech users afterwards?

@Dzahn: Not in the special case of ldap/wmf though, per SRE instructions

Oops, of course you are absolutely right there, Andre.

We added pfischer to the WMF LDAP group per these instructions , and added him to the WMF-NDA phabricator group.

Peter, please test out this access and let us know if we need to fix/change anything.

@bking, thanks! I works, at least I'm able to log into thanos and grafana-rw, now. Do you still need my SSH public key? Would the one suffice I use for gerrit or would you recommend generating a separate one?

@pfischer After I asked for your public key, it looks like someone updated the original request with the key. Thus, I believe you should have access already. Can you try logging into an elastic and/or wdqs server and let us know if you can get in? Also, if you could verify root access via sudo -i, that would be helpful as well. Thanks!

Hi @pfischer You are in the requested wmf LDAP group and the WMF-NDA group in Phabricator meanwhle.

If you could confirm that you can login at logstash/turnilo/grafana (and ideally also that you can read a non-public ticket) then we can close this ticket.