Page MenuHomePhabricator
Create Task
Maniphest T317018

Make HtmlOutputRendererHelper use ParserOutputAccess
Closed, ResolvedPublic
Actions

Description

HtmlOutputRendererHelper use ParserOutputAccess, rather than the temporary stand-in ParsoidOutputAccess. This will enable:

  • support for all content models, not just the ones supported by Parsoid
  • support for multi-slot ouotput
  • stampede protection

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[HtmlOutputRendererHelper] Remove use of ParsoidOutputAccess::parseUncacheablemediawiki/coremaster+135 -153
Ensure ParsoidOutputAccess is @deprecated before 1.40mediawiki/coremaster+5 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Sep 5 2022, 9:30 AM
daniel triaged this task as High priority.
daniel added a parent task: T311728: Gracefully handle non-wikitext pages when returning HTML from the page endpoints.
daniel moved this task from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
daniel added a subtask: T311648: Allow WikitextContentHandler to use Parsoid for rendering wikitext.
daniel lowered the priority of this task from High to Medium.Oct 18 2022, 2:45 PM
daniel renamed this task from Make ParsoidHTMLHelper use ParserOutputAccess to Make HtmlOutputRendererHelper use ParserOutputAccess.Oct 20 2022, 5:30 PM
daniel updated the task description. (Show Details)
daniel moved this task from VE Backend pile to Blocked on the Platform Team Workboards (MW Expedition) board.
daniel added a project: RESTBase Sunsetting.Dec 6 2022, 3:32 PM
daniel moved this task from Unsorted to Blocked on the RESTBase Sunsetting board.Dec 6 2022, 3:32 PM
xSavitar removed a project: User-xSavitar.Jan 27 2023, 12:44 PM
xSavitar edited subscribers, added: DAlangi_WMF; removed: xSavitar.
gerritbot added a comment.Mar 7 2023, 10:36 PM

Change 895366 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Ensure ParsoidOutputAccess is @deprecated before 1.40

https://gerrit.wikimedia.org/r/895366

gerritbot added a project: Patch-For-Review.Mar 7 2023, 10:36 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 12 2023, 9:25 PM
ssastry added a parent task: T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry.Mar 23 2023, 7:14 PM
gerritbot added a comment.Mar 28 2023, 3:41 PM

Change 895366 abandoned by C. Scott Ananian:

[mediawiki/core@master] Ensure ParsoidOutputAccess is @deprecated before 1.40

Reason:

It's @unstable already, that's good enough I guess.

https://gerrit.wikimedia.org/r/895366

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2023, 4:11 PM
daniel mentioned this in T330772: Mobile-html switchover to REST API (from RESTBase) should account for http 400 response for non-wikitext content models.Apr 3 2023, 9:58 AM
Seddon subscribed.May 23 2023, 12:00 PM

@cscott any idea when this task could get picked up?

MSantos updated the task description. (Show Details)May 25 2023, 11:17 AM
daniel mentioned this in T324711: UnexpectedValueException: Parsoid does not support content model proofread-index.Jun 16 2023, 11:17 AM
Kelson added a project: affects-Kiwix-and-openZIM.Jun 19 2023, 7:06 AM
ssastry subscribed.Oct 17 2023, 1:42 AM

I am going to make this a duplicate of T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry since that is what I ended up tagging in all my patches.

ssastry closed this task as a duplicate of T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry.Oct 17 2023, 1:42 AM
ssastry reopened this task as Open.Oct 17 2023, 1:45 AM
ssastry claimed this task.
ssastry added projects: Content-Transform-Team-WIP, Parsoid-Read-Views.

Ugh ... looks like I had made this a subtask of the other one and just forgot all about this in my patches. Sorry about all the noise. I'll just add the appropriate project tags and close them all together!

Restricted Application added a project: Parsoid. · View Herald TranscriptOct 17 2023, 1:45 AM
ssastry moved this task from Backlog to To Deploy on the Content-Transform-Team-WIP board.Oct 17 2023, 1:46 AM
daniel updated the task description. (Show Details)Oct 17 2023, 6:40 AM
MSantos removed a project: Parsoid.Oct 19 2023, 2:17 PM
ssastry added a comment.Oct 23 2023, 4:53 PM

The first step of this process is done. ParsoidOutputAccess is a thin wrapper over ParserOutputAccess and unblocks the parent tasks. I am going to remove this as a subtask and also remove the read views tag since the rest of the work is primarily tech debt removal.

ssastry edited projects, added Technical-Debt, Content-Transform-Team; removed Parsoid-Read-Views, Content-Transform-Team-WIP, affects-Kiwix-and-openZIM.Oct 23 2023, 4:54 PM
ssastry removed parent tasks: T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry, T311728: Gracefully handle non-wikitext pages when returning HTML from the page endpoints, T264669: Move VE API from RESTBase into core..
MSantos moved this task from Backlog to Later on the Content-Transform-Team board.Oct 26 2023, 2:20 PM

Moving to later but we still have the open question about how/if to proceed with the deprecation of ParsoidOutputAccess.

MSantos closed subtask T311648: Allow WikitextContentHandler to use Parsoid for rendering wikitext as Resolved.Oct 26 2023, 2:23 PM
daniel mentioned this in T359426: REST: endpoints that return rendered page content should support all content models.Mar 6 2024, 5:17 PM
cscott mentioned this in T367074: Deprecate and remove ParsoidOutputAccess.Jun 10 2024, 3:44 PM
Jdforrester-WMF added a parent task: T367074: Deprecate and remove ParsoidOutputAccess.Jun 10 2024, 7:38 PM
gerritbot added a comment.Jun 11 2024, 1:07 AM

Change #1032576 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [HtmlOutputRendererHelper] Remove use of ParsoidOutputAccess::parseUncacheable

https://gerrit.wikimedia.org/r/1032576

gerritbot added a project: Patch-For-Review.Jun 11 2024, 1:07 AM
gerritbot added a comment.Jul 19 2024, 11:13 AM

Change #1032576 merged by jenkins-bot:

[mediawiki/core@master] [HtmlOutputRendererHelper] Remove use of ParsoidOutputAccess::parseUncacheable

https://gerrit.wikimedia.org/r/1032576

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2024, 11:31 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 19 2024, 12:00 PM
MSantos removed projects: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), RESTBase Sunsetting, Platform Team Workboards (MW Expedition).Nov 21 2024, 11:04 AM

I'm removing the RESTBase Sunsetting tag as this seems to not be work required for its completion. Please re-add it in case I'm wrong.

cscott edited projects, added Content-Transform-Team (Work In Progress); removed Content-Transform-Team.May 1 2025, 2:18 PM
cscott moved this task from Backlog to To Verify on the Content-Transform-Team (Work In Progress) board.
MSantos added a project: Essential-Work.May 5 2025, 1:30 PM
ssastry closed this task as Resolved.May 20 2025, 7:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits