Page MenuHomePhabricator
Create Task
Maniphest T317035

Multiple new topic tools are opening for DT after making an edit in NWE
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

Pre-requisite: Make sure you have enabled DT

  1. Go to this page: https://en.wikipedia.org/wiki/User_talk:RYasmeen_(WMF)/sandbox.
  1. Make an edit on that page.
  1. Click on the "New Section" link to add a new section.

Observe that, multiple new topic tools are opening.

Environment: en.wiki, beta cluster

Screen Shot 2022-09-05 at 3.36.24 PM.png (1×2 px, 268 KB)

Details

SubjectRepoBranchLines +/-
Special case opening new topic tool when VE or 2017WTE is openmediawiki/extensions/DiscussionToolsmaster+12 -6
Always reset ReplyLinksController before re-initializingmediawiki/extensions/DiscussionToolsmaster+11 -4
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Sep 5 2022, 1:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2022, 1:47 PM
Esanders subscribed.Sep 5 2022, 4:27 PM
  1. Make an edit on that page.

Presumably this only happens with the 2017WTE?

Ryasmeen added a comment.EditedSep 6 2022, 1:42 AM
In T317035#8212122, @Esanders wrote:
  1. Make an edit on that page.

Presumably this only happens with the 2017WTE?

Yes, that's right, doesn't happen with the OWE.

matmarex subscribed.Sep 6 2022, 4:12 AM

Probably related to T317005.

DLynch mentioned this in T319333: Infinite number of new topic tools in full-page editor.Oct 5 2022, 6:52 AM
matmarex added a comment.Oct 10 2022, 10:28 PM

Doesn't seem to be related to T317005 after all.

matmarex renamed this task from [Regression wmf.27] Multiple new topic tools are opening for DT after making an edit to [Regression wmf.27] Multiple new topic tools are opening for DT after making an edit in NWE.Oct 10 2022, 10:29 PM
• ppelberg added a project: Editing-team.Dec 1 2022, 4:29 PM
• ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.
• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
• ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Jan 9 2023, 5:52 PM
• ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jan 24 2023, 3:44 PM

Change 883199 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Always reset ReplyLinksController before re-initializing

https://gerrit.wikimedia.org/r/883199

gerritbot added a project: Patch-For-Review.Jan 24 2023, 3:44 PM
matmarex claimed this task.Jan 24 2023, 3:44 PM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Feb 2 2023, 6:04 PM

Change 883199 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Always reset ReplyLinksController before re-initializing

https://gerrit.wikimedia.org/r/883199

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 6:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 2 2023, 7:00 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Feb 2 2023, 7:53 PM
matmarex added a project: Editing QA.
EAkinloose subscribed.Feb 6 2023, 5:24 PM

Only one new topic tool opens as expected. See

Screenshot 2023-02-06 at 18.22.56.png (1×2 px, 210 KB)

However, I get stuck while trying to switch between edit and add topic when I have a draft that is pending save. See 00:10 in https://photos.app.goo.gl/YzJ7VoL9P31tyPFt5
Screenshot 2023-02-06 at 18.21.28.png (1×3 px, 1 MB)

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Feb 6 2023, 5:24 PM
matmarex added a comment.Feb 6 2023, 6:10 PM

However, I get stuck while trying to switch between edit and add topic when I have a draft that is pending save.

Thanks for spotting that. I think it's an old issue and we just didn't notice it before. Might as well fix it here, though.

gerritbot added a comment.Feb 6 2023, 6:11 PM

Change 886928 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Special case opening new topic tool when VE or 2017WTE is open

https://gerrit.wikimedia.org/r/886928

gerritbot added a project: Patch-For-Review.Feb 6 2023, 6:11 PM
matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Feb 6 2023, 6:12 PM
matmarex removed a project: Editing QA.
matmarex renamed this task from [Regression wmf.27] Multiple new topic tools are opening for DT after making an edit in NWE to Multiple new topic tools are opening for DT after making an edit in NWE.Feb 6 2023, 6:18 PM
matmarex mentioned this in T329523: Reply tool "Show 1 new comment" button causes the tool to disappear, doesn't show new comments.Feb 13 2023, 2:37 PM
gerritbot added a comment.Feb 16 2023, 4:47 PM

Change 886928 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Special case opening new topic tool when VE or 2017WTE is open

https://gerrit.wikimedia.org/r/886928

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Feb 16 2023, 4:48 PM
DLynch added a project: Editing QA.
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 16 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 5:10 PM
EAkinloose edited projects, added Verified; removed Editing QA.Apr 21 2023, 10:46 PM
In T317035#8590357, @EAkinloose wrote:

Only one new topic tool opens as expected. See

Screenshot 2023-02-06 at 18.22.56.png (1×2 px, 210 KB)

However, I get stuck while trying to switch between edit and add topic when I have a draft that is pending save. See 00:10 in https://photos.app.goo.gl/YzJ7VoL9P31tyPFt5
Screenshot 2023-02-06 at 18.21.28.png (1×3 px, 1 MB)

This works as expected now.

EAkinloose closed this task as Resolved.Apr 21 2023, 10:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL