Page MenuHomePhabricator

Custom logo function not working
Closed, ResolvedPublicBUG REPORT

Description

The WikimediaIncubator extension has a function (fnTestWikiLogo) that is supposed to customize the logo of a test project by creating a page named MediaWiki:Incubator-logo-wx-xxx with the file name of a logo for that test wiki. However, that function is not working in any skin. Line 933 in the code has a FIXME that says "This really shouldn't be writing to site config like this (and certainly not through globals).".

The feature is practically unknown, and is used (or attempted to be used) very little – only three pages match the required page name pattern.

In order to test it, you have to add ?testwiki=wx/xxx to the URL and be on the test wiki itself, so with such a limited scope, this malfunction may have gone unreported for years.

Given that (a) the function does things in the wrong way and (b) it has very little (attempted) use, I vote that we just remove the function from the extension altogether, in favour of handling it with on-wiki JS instead. Any objections? Ping @MF-Warburg @Sotiale @Hydriz @Ebe123

Event Timeline

jhsoby changed the subtype of this task from "Task" to "Bug Report".Sep 6 2022, 11:27 AM
jhsoby moved this task from Backlog to Bugs on the MediaWiki-extensions-WikimediaIncubator board.
jhsoby updated the task description. (Show Details)

Also: There is already an on-wiki gadget that does basically the same thing, and has existed since 2013, indicating that this function has been non-working for quite some time.

Hi. I haven't been asked to use this feature recently. Few people probably know about this feature. If onwiki javascript can cover this, and if it's nothing else to concern about on the server side, then removing this feature is unlikely to have a negative impact.

Change 833708 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/WikimediaIncubator@master] Remove custom logo function

https://gerrit.wikimedia.org/r/833708

Change 833708 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Remove custom logo function

https://gerrit.wikimedia.org/r/833708

jhsoby claimed this task.