Page MenuHomePhabricator

Stop multilingual strings from accepting duplicate languages when language is forced into the Lookup field
Closed, ResolvedPublic

Description

Steps to reproduce

Observed behavior

  • Directly type Z1003 into the Lookup field
  • Select Z1003 (Spanish)
  • The existing value for Spanish is removed
  • Write a label
  • The string is written in both fields
  • Observe the JSON representation: one Spanish label is there with the new string and another with the old string

Expected behavior

  • No Z1003 Spanish value can be entered
  • When the value is selected (with the mouse, or pressing enter or tab) we should check whether the value is duplicated

Additional information

Event Timeline

Change 830879 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Ensure duplicate languages can't be selected through typing the ZID directly.

https://gerrit.wikimedia.org/r/830879

Change 830879 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Ensure duplicate languages can't be selected through typing the ZID directly.

https://gerrit.wikimedia.org/r/830879

gengh assigned this task to Ddwaal.