Page MenuHomePhabricator

Ensure that post-edit dialog works when help panel preference is disabled
Open, MediumPublicBUG REPORT

Description

We allow users to do a suggested edit even if the help panel editor preference isn't checked (see T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together and rEGREc9be127cdbe3: SuggestedEdits: Always load help panel when doing a newcomer task. We need to ensure that we also allow the post-edit dialog to function in this scenario.


Steps to replicate the issue (include links if applicable):

What happens?:
After publishing an Add a link or Add an Image edit, no further suggestions nor additional messages are shown and nothing else happens either, just the edited article is displayed. If the user wants to keep using the tools, they have to go back to the newcomer homepage to find more suggestions.

What should have happened instead?:
After publishing a structured edit, a thank you message should be displayed and a new suggested edit should be shown immediately.

Other information (browser name/version, screenshots, etc.):

  • This is not happening for all users, but happens consistently per user (so @Urbanecm_WMF suggested that could be related to any enabled gadget).
  • The daily task limit has not been reached yet and there are more suggested edits available.
  • It happens at least at es.wp and pt.wp.

Event Timeline

Thanks for reporting @Zapipedia-WMF ! Let us know if you can think of a particular gadget or setting you enabled recently that could impact this Growth feature.

I just tested "add a link" via en.wikipedia.beta on Chrome, and I received another suggestion after I completed the edit. I then enabled all Beta features and switched to Vector 2022, and still I can't replicate this.
However, it sounds like this might only impact some users based on user settings or enabled gadgets or something, and so there are certainly many more variations to be tested.

@Zapipedia-WMF can you please open your browser console, save an add link or add image task, and let us know if you see any errors or warnings printed after save?

Hi @kostajh. In my browser console appears the last line you can see in these images after completing one of the task. Now I am deactivating my gadgets one by one trying to figure out where the problem could be... but with no success so far. If I find something I will inform it here. Thank you.

image.png (424×1 px, 261 KB)
image.png (418×1 px, 266 KB)

I can't reproduce it (Firefox/Ubuntu).

In T317154#8217084, @Zapipedia-WMF wrote:

Hi @kostajh. In my browser console appears the last line you can see in these images after completing one of the task. Now I am deactivating my gadgets one by one trying to figure out where the problem could be... but with no success so far. If I find something I will inform it here. Thank you.

image.png (424×1 px, 261 KB)
image.png (418×1 px, 266 KB)

Thanks @Zapipedia-WMF. Those messages seem unrelated–they have to do with an ad blocker in your browser that is preventing Wikimedia code from sending analytics data to the analytics intake service.

I have deactivated all my gadgets and beta functions and the problem is still happening (tested in Chrome, Firefox and Safari, both with Vector 2010 and Vector 2022). With another account where the tools were working normally, I have activated all the gadgets and beta functions and both tools keeps working well.

Could someone provide a URL where to test this? (Please include URLs so there is no need for guessing - thanks.)

Could someone provide a URL where to test this? (Please include URLs so there is no need for guessing - thanks.)

I edited the task description.

The bug report comes from an internal discussion within the Growth team about a tool we develop. Hence the shortcuts we took to describe the problem. Sorry.

In T317154#8217692, @Zapipedia-WMF wrote:

I have deactivated all my gadgets and beta functions and the problem is still happening (tested in Chrome, Firefox and Safari, both with Vector 2010 and Vector 2022). With another account where the tools were working normally, I have activated all the gadgets and beta functions and both tools keeps working well.

@Zapipedia-WMF,
Is you other account logged-in using the same browsers you tested?
If you use an incognito mode for you other account, are the extensions (such as the ad-blocker) active in incognito mode?

Yes, I used the same browsers with the other account and always in the same visible mode. None adblockers are activated. And, just in case, I have tried now in incognito mode, and everything works the same. I have also tested it from my mobile (iOS 15).

Just to clarify, this bug is not just happening to me with my accounts and my computer. It happens to other users that use different SO and browsers too. I discovered the bug during an onsite session, so I could witnessed myself the issue is not experienced by all users but it happens consistently by each given user, as I said in the initial report. I also tested the features at Portuguese Wikipedia with my accounts, and is happening the same there too.

I don't know if it makes sense, but the only common link I can think of is that all users experiencing this bug have at some point enabled the Growth features manually in their Preferences. The users who can normally use the Growth features are the ones who received them automatically.

Please, if you want me to test the features in any different way, just let me know. Thank you very much for your help.

In T317154#8218157, @Zapipedia-WMF wrote:

I don't know if it makes sense, but the only common link I can think of is that all users experiencing this bug have at some point enabled the Growth features manually in their Preferences. The users who can normally use the Growth features are the ones who received them automatically.

Please, if you want me to test the features in any different way, just let me know. Thank you very much for your help.

Thanks @Zapipedia-WMF for more details - can you check if "Enable the editor help panel" is enabled in your preferences? There is a report that the post-edit dialog doesn't appear if Help panel is disabled. T312182: [minor] Post-edit dialog is not present for Structured task if "Enable the editor help panel" is disabled

@Etonkovidova indeed it was disabled. I have activated "Enable the editor help panel" now and finally Add a Link and Add an Image work properly again.

In T317154#8220490, @Zapipedia-WMF wrote:

@Etonkovidova indeed it was disabled. I have activated "Enable the editor help panel" now and finally Add a Link and Add an Image work properly again.

💡 well spotted, @Etonkovidova!

kostajh renamed this task from Add a Link and Add an Image: after publish an edit, no more suggestions are displayed to Ensure that post-edit dialog works when help panel preference is disabled.Sep 8 2022, 10:38 AM
kostajh triaged this task as Medium priority.
kostajh updated the task description. (Show Details)
In T317154#8220490, @Zapipedia-WMF wrote:

@Etonkovidova indeed it was disabled. I have activated "Enable the editor help panel" now and finally Add a Link and Add an Image work properly again.

Thanks a lot @Zapipedia-WMF for confirming!