Remove getPermissionsError from GlobalBlock
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Sep 7 2022, 2:56 PM

Description

Background

AbstractBlock::getPermissionsError is deprecated and just calls the BlockErrorFormatter in most block classes. GlobalBlock still uses it to add a custom error message, but it appears that the method is never called: https://codesearch.wmcloud.org/search/?q=getPermissionsError&i=nope&files=&excludeFiles=&repos=

Acceptance criteria

GlobalBlock::getPermissionsError is removed

Notes

Documentation on the deprecation/removal process: https://www.mediawiki.org/wiki/Stable_interface_policy#Deprecation_process

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove getPermissionsError from GlobalBlock	mediawiki/extensions/GlobalBlocking	master	+0 -8

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Spike	None	T315644 Global blocks should be treated as a subtype of blocks
Resolved		Cyndymediawiksim	T317206 Hard deprecate AbstractBlock::getPermissionsError
Resolved		Cyndymediawiksim	T317204 Remove getPermissionsError from GlobalBlock
Resolved		• AGueyte	T317201 Allow extensions to modify block error message key via a hook
Resolved		Tchanders	T322553 Remove use of AbstractBlock::getPermissionsError from CheckBlocksSecondaryAuthenticationProvider

Event Timeline

Tchanders created this task.Sep 7 2022, 2:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2022, 2:56 PM

Tchanders mentioned this in T317206: Hard deprecate AbstractBlock::getPermissionsError.Sep 7 2022, 3:01 PM

Tchanders added a parent task: T317206: Hard deprecate AbstractBlock::getPermissionsError.Sep 8 2022, 2:31 PM

FWIW https://gerrit.wikimedia.org/r/c/mediawiki/core/+/824142 would reintroduce a call to this method. In general I think it's the only way to get an error message for a global block; the only reason it's not used is that nothing tries to show an error message for a global block currently (except the permission system, which uses a different hook). But it's a legitimate use case.

T317201: Allow extensions to modify block error message key via a hook would fully obsolete the method, though.

Tchanders added a subtask: T317201: Allow extensions to modify block error message key via a hook.Sep 9 2022, 12:05 PM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Sep 9 2022, 3:36 PM

Tchanders set the point value for this task to 1.Oct 11 2022, 5:46 PM

Tchanders moved this task from Triage/To be Estimated to AHaT Sprint 19: The Deerstalker on the Anti-Harassment-Team board.Nov 1 2022, 5:02 PM

Tchanders edited projects, added Anti-Harassment-Team (AHaT Sprint 19: The Deerstalker); removed Anti-Harassment-Team.

Tchanders updated the task description. (Show Details)Nov 1 2022, 5:06 PM

Cyndymediawiksim claimed this task.Nov 2 2022, 3:32 PM

Cyndymediawiksim moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 19: The Deerstalker) board.

Change 853926 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GlobalBlocking@master] Remove getPermissionsError from GlobalBlock

https://gerrit.wikimedia.org/r/853926