Maniphest T317206

Hard deprecate AbstractBlock::getPermissionsError
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Cyndymediawiksim

Authored By

	Tchanders
	Sep 7 2022, 3:01 PM

Tags

Referenced Files

None

Subscribers

Description

AbstractBlock::getPermissionsError is never called (https://codesearch.wmcloud.org/search/?q=getPermissionsError&i=nope&files=&excludeFiles=&repos=) and after T317204 it will never be used.

Acceptance criteria

AbstractBlock::getPermissionsError is hard deprecated: its deprecation is documented, and calling it emits deprecation warnings

Notes

Documentation on the deprecation process: https://www.mediawiki.org/wiki/Stable_interface_policy#Deprecation_process
Example of hard deprecating method: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/812549

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+4 -1	Hard deprecate AbstractBlock::getPermissionsError

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	Spike	None	T315644 Global blocks should be treated as a subtype of blocks
		Resolved		Cyndymediawiksim	T317206 Hard deprecate AbstractBlock::getPermissionsError
		Resolved		Cyndymediawiksim	T317204 Remove getPermissionsError from GlobalBlock
		Resolved		AGueyte	T317201 Allow extensions to modify block error message key via a hook
		Resolved		Tchanders	T322553 Remove use of AbstractBlock::getPermissionsError from CheckBlocksSecondaryAuthenticationProvider

Event Timeline

Tchanders created this task.Sep 7 2022, 3:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2022, 3:01 PM

Tchanders added a subtask: T317204: Remove getPermissionsError from GlobalBlock.Sep 8 2022, 2:31 PM

Tchanders added a parent task: T315644: Global blocks should be treated as a subtype of blocks.Sep 8 2022, 4:39 PM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Sep 9 2022, 3:36 PM

Tchanders set the point value for this task to 1.Oct 11 2022, 5:45 PM

Tchanders moved this task from Triage/To be Estimated to AHaT Sprint 19: The Deerstalker on the Anti-Harassment board.Nov 1 2022, 5:02 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 19: The Deerstalker); removed Anti-Harassment.

Tchanders updated the task description. (Show Details)

Cyndymediawiksim claimed this task.Nov 2 2022, 7:50 AM

Cyndymediawiksim moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 19: The Deerstalker) board.

Change 853937 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/core@master] Hard deprecate AbstractBlock::getPermissionsError

https://gerrit.wikimedia.org/r/853937

gerritbot added a project: Patch-For-Review.Nov 7 2022, 10:32 AM

Cyndymediawiksim moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 19: The Deerstalker) board.Nov 7 2022, 2:32 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 19: The Sanbenito); removed Anti-Harassment (AHaT Sprint 19: The Deerstalker).Nov 8 2022, 5:24 AM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.

Tchanders moved this task from Blocked/Stalled 🚧 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.Nov 18 2022, 7:14 AM

ARamirez_WMF edited projects, added Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat); removed Anti-Harassment (AHaT Sprint 19: The Sanbenito).Nov 22 2022, 6:25 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.

AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.Nov 23 2022, 2:43 PM

Change 853937 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate AbstractBlock::getPermissionsError

https://gerrit.wikimedia.org/r/853937

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 23 2022, 3:01 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 23 2022, 3:30 PM

Tchanders moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.Nov 23 2022, 4:49 PM

Niharika closed this task as Resolved.Dec 8 2022, 1:09 AM

Niharika closed subtask T317204: Remove getPermissionsError from GlobalBlock as Resolved.Mar 1 2023, 1:37 AM