APIUpload and SpecialUpload check for global blocks separately from other blocks. If a global block is found, it blocks upload.
This is an example of MediaWiki core being aware of an extension.
Instead, the GlobalBlock itself should define that it blocks upload.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| GlobalBlock::appliesToRight returns true for 'upload' | mediawiki/extensions/GlobalBlocking | master | +12 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T231109 Remove Core coupling with GlobalBlocking extension | |||
| Open | None | T319069 Remove global-blocks-specific methods and hook from User class | |||
| Open | Spike | None | T315644 Global blocks should be treated as a subtype of blocks | ||
| Resolved | Cyndymediawiksim | T317337 Deprecate global-blocks-specific methods and hook | |||
| Resolved | Cyndymediawiksim | T317325 Remove separate checks for global blocks from APIUpload and SpecialUpload | |||
| Resolved | Cyndymediawiksim | T317324 GlobalBlock::appliesToRight should return true for 'upload' |
It should also return true for createaccount, I think. Or maybe it should do that depending on the value of the anonOnly flag? Not sure what's the expected behavior for anon-only global blocks (or the current behavior, for that matter).
Currently, all global blocks block account creation. (T17273: Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation)
Change 835200 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):
[mediawiki/extensions/GlobalBlocking@master] GlobalBlock::appliesToRight returns true for 'upload'
Change 835200 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] GlobalBlock::appliesToRight returns true for 'upload'
Since global blocks all block create account then I think appliesToRight this should return true for createaccount, to make that explicit. I've written this up in T318827: GlobalBlock::isCreateAccountBlocked should return true.
This needn't stand in the way of T17273: Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation; we'd just need to make sure GlobalBlock::isCreateAccountBlocked returns the correct value for createaccount once that work is done.
Bypassing QA for this one, since it isn't a functional change and regression testing should be done along with T317325: Remove separate checks for global blocks from APIUpload and SpecialUpload.