Page MenuHomePhabricator

Add liftwing-specific API gateway configuration
Closed, ResolvedPublic

Description

Currently we are reaching the edges of what is sustainable to add to the discovery_services endpoint. We need to add further logic that is unlikely to be needed elsewhere and we should move liftwing endpoints to their own configuration section.

This work also requies us to have the ability to internally set the host header based on URL path for a single internal cluster. For example having lw/abc and lw/xyz both hit inference.discovery.wmnet but with a different host header set for abc and xyz respectively.

Event Timeline

Did some prep work based on what Tobias and I have previously talked about - I think we can avoid making LW-specific configuration by writing services using this pattern. It'll great some redundant cluster definitions but it shouldn't be an issue for Envoy itself. Hopefully this will satsify requirements and save us all time.

Change 844452 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/deployment-charts@master] api-gateway: create fine-grained liftwing API definitions

https://gerrit.wikimedia.org/r/844452

Change 844452 merged by jenkins-bot:

[operations/deployment-charts@master] api-gateway: create fine-grained liftwing API definitions

https://gerrit.wikimedia.org/r/844452

Change 862851 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/deployment-charts@master] api-gateway: Correct behaviour when handling multiple regexes in path

https://gerrit.wikimedia.org/r/862851

Change 862851 merged by jenkins-bot:

[operations/deployment-charts@master] api-gateway: Correct behaviour when handling multiple regexes in path

https://gerrit.wikimedia.org/r/862851

Change 863021 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/deployment-charts@master] api-gateway: add option to remove part of url path

https://gerrit.wikimedia.org/r/863021

Change 863021 merged by jenkins-bot:

[operations/deployment-charts@master] api-gateway: add option to remove part of url path

https://gerrit.wikimedia.org/r/863021