Page MenuHomePhabricator

Investigate: Remove use of User::isBlockedGlobally and User::getGlobalBlock from Wikimedia deployed extensions
Closed, ResolvedPublic

Description

Background

Several extensions use User::getGlobalBlock and User::isBlockedGlobally, which will be deprecated in T317337.

These methods should no longer be called by extensions. Depending on the use-case, one of the following may need to happen instead:

What should be done

File a task for each extension that calls User::getGlobalBlock and/or User::isBlockedGlobally, with a suggested strategy for how to remove these calls

Related Objects

StatusSubtypeAssignedTask
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
OpenSpikeNone
ResolvedCyndymediawiksim
Resolved TThoabala
ResolvedDreamy_Jazz
Resolved AGueyte
ResolvedWMDE-Fisch
Resolved AGueyte
ResolvedCyndymediawiksim
ResolvedCyndymediawiksim
ResolvedUniversal_Omega
ResolvedTchanders
ResolvedTchanders
Resolved AGueyte
ResolvedSTran
Resolvedmatmarex

Event Timeline

There are more uses of User::isBlockedGlobally in lingua-libre/* and in examknow/ should tickets be created for these as well?

There are more uses of User::isBlockedGlobally in lingua-libre/* and in examknow/ should tickets be created for these as well?

Possibly, but I think most importantly we will follow a proper deprecation process in T317337: Deprecate global-blocks-specific methods and hook, including updating release notes and making the functions available but deprecated, then later throwing deprecation warnings, before removing the methods from core.

Thanks for filing the tasks. From the ones I've looked at so far, I think they still need this:

[...] with a suggested strategy for how to remove these calls

We should state, on each task, whether they can do one of the bullet points from the task description, or whether they need to do something else. I suspect it depends on how they use the global blocks they find.

It would be helpful to have a summary on this task of how the different extensions use global blocks.

We should state, on each task, whether they can do one of the bullet points from the task description, or whether they need to do something else. I suspect it depends on how they use the global blocks they find

As discussed with @STran this will be done on a task by task basis by the person picking up the task.