PHP Notice: Trying to access array offset on value of type null (in HTMLCentralNoticeBannerMessage)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	TheresNoTime
	Sep 8 2022, 9:01 PM

Description

Error

mwversion: 1.39.0-wmf.28
reqId: 728482d5-edc5-4644-8184-560aafcc8e96
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Trying to access array offset on value of type null

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.28/extensions/CentralNotice/includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php(42)
#0 /srv/mediawiki/php-1.39.0-wmf.28/extensions/CentralNotice/includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php(42): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLForm.php(559): HTMLCentralNoticeBannerMessage->__construct(array)
#2 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLForm.php(407): HTMLForm::loadInputFromParameters(string, array, CentralNoticeHtmlForm)
#3 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLForm.php(384): HTMLForm->addFields(array)
#4 /srv/mediawiki/php-1.39.0-wmf.28/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(506): HTMLForm->__construct(array, RequestContext, string)
#5 /srv/mediawiki/php-1.39.0-wmf.28/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(93): SpecialCentralNoticeBanners->showBannerEditor()
#6 /srv/mediawiki/php-1.39.0-wmf.28/includes/specialpage/SpecialPage.php(701): SpecialCentralNoticeBanners->execute(string)
#7 /srv/mediawiki/php-1.39.0-wmf.28/includes/specialpage/SpecialPageFactory.php(1428): SpecialPage->run(string)
#8 /srv/mediawiki/php-1.39.0-wmf.28/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#9 /srv/mediawiki/php-1.39.0-wmf.28/includes/MediaWiki.php(904): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.39.0-wmf.28/includes/MediaWiki.php(562): MediaWiki->main()
#11 /srv/mediawiki/php-1.39.0-wmf.28/index.php(50): MediaWiki->run()
#12 /srv/mediawiki/php-1.39.0-wmf.28/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Impact

Notes

Only a single spike of ~18 events

Details

Request URL: https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/Discussion_Tools_feedback2

	Subject	Repo	Branch	Lines +/-
	HTMLCentralNoticeBannerMessage: Do not use mParams in constructor	mediawiki/extensions/CentralNotice	master	+2 -2

Customize query in gerrit

Event Timeline

TheresNoTime created this task.Sep 8 2022, 9:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2022, 9:01 PM

TheresNoTime added a project: MediaWiki-extensions-CentralNotice.Sep 8 2022, 9:03 PM

TheresNoTime updated the task description. (Show Details)Sep 8 2022, 9:06 PM

Umherirrender renamed this task from PHP Notice: Trying to access array offset on value of type null to PHP Notice: Trying to access array offset on value of type null (in HTMLCentralNoticeBannerMessage).Sep 16 2022, 9:27 PM

Umherirrender added a project: PHP 7.4 support.

Change 832709 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] HTMLCentralNoticeBannerMessage: Do not use mParams in constructor

https://gerrit.wikimedia.org/r/832709

gerritbot added a project: Patch-For-Review.Sep 16 2022, 9:30 PM

Umherirrender claimed this task.Sep 16 2022, 9:37 PM

Change 832709 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] HTMLCentralNoticeBannerMessage: Do not use mParams in constructor

https://gerrit.wikimedia.org/r/832709

Umherirrender closed this task as Resolved.Sep 18 2022, 5:07 PM

Umherirrender removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 18 2022, 6:00 PM

Krinkle moved this task from Untriaged to Sep 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:22 PM

PHP Notice: Trying to access array offset on value of type null (in HTMLCentralNoticeBannerMessage)Closed, ResolvedPublicPRODUCTION ERRORActions