Page MenuHomePhabricator

[S] Restore original navigation landmarks in the page toolbar
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

T291304 simplified and reduced the number of nav landmarks in modern Vector, which removed landmarks that were poorly named or didn't contain enough links. This reduces the overhead for new screenreader users to learn navigation on the site by reducing the number of navigation options.

However, there were concerns around how could impact existing screenreaders users who would have to learn these changes. This task is for restoring some of the original landmarks, which will likely be subject to change in the future with the navigation restructure epic anyway.

Currently:

Screen Shot 2022-09-09 at 2.34.07 PM.png (1×2 px, 475 KB)

Proposed:

Screen Shot 2022-09-09 at 2.35.10 PM.png (1×2 px, 490 KB)

The proposed change restores the "namespaces", "views" and "more options" landmarks.

AC

  • The "tools" navigation landmark is replaced with "namespaces", "views" and "more options"
  • No visual changes

Developer notes

Given this is likely temporary until the navigation restructure work, the landmarks can be added manually in the ArticleToolbar.mustache template, by wrapping the Menu template with a <nav> element.

To note, in legacy Vector the "language variants" dropdown had it's own nav landmark. In this task we will still be merging it into "namespaces" for the following reasons:

  1. Language variants isn't on all wikis, its relatively lower impact
  2. It only contains 1 dropdown, so it probably doesn't deserve it's own landmark to begin with
  3. It will likely be moved/reworked along with the entire page toolbar in the navigation restructure work

QA Results - Beta|

ACStatusDetails
1T317440#8301342
2T317440#8301342

QA Results - Prod

ACStatusDetails
1T317440#8301348
2T317440#8301348

Event Timeline

bwang renamed this task from Reevalute page toolbar navigation landmark to Restore original navigation landmarks in the page toolbar.Sep 9 2022, 7:48 PM
bwang updated the task description. (Show Details)
Volker_E subscribed.

The three landmarks as laid out make sense to me.

Are there any implication on cached HTML or gadgets with this one?

@Jdlrobson Yes there would be HTML changes with this, but I believe cached HTML wont be a problem if we go with the approach of simply adding a container element.

bwang updated the task description. (Show Details)

Change 835225 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Restore navigation landmarks in page toolbar

https://gerrit.wikimedia.org/r/835225

Jdrewniak subscribed.
Jdlrobson renamed this task from Restore original navigation landmarks in the page toolbar to [S] Restore original navigation landmarks in the page toolbar.Oct 3 2022, 5:34 PM
Jdlrobson changed the point value for this task from 2 to 1.

Change 835225 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Restore navigation landmarks in page toolbar

https://gerrit.wikimedia.org/r/835225

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The "tools" navigation landmark is replaced with "namespaces", "views" and "more options"

Screen Shot 2022-10-07 at 1.37.27 PM.png (434×1 px, 127 KB)

Screen Shot 2022-10-07 at 1.37.38 PM.png (427×1 px, 122 KB)

Screen Shot 2022-10-07 at 1.37.52 PM.png (451×1 px, 128 KB)

Screen Shot 2022-10-07 at 1.34.10 PM.png (861×1 px, 344 KB)

Screen Shot 2022-10-07 at 1.34.27 PM.png (876×1 px, 345 KB)

Screen Shot 2022-10-07 at 1.34.46 PM.png (885×1 px, 347 KB)

✅ AC2: No visual changes
No changes observed.

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The "tools" navigation landmark is replaced with "namespaces", "views" and "more options"

Screen Shot 2022-10-07 at 1.37.27 PM.png (434×1 px, 127 KB)

Screen Shot 2022-10-07 at 1.37.38 PM.png (427×1 px, 122 KB)

Screen Shot 2022-10-07 at 1.37.52 PM.png (451×1 px, 128 KB)

Screen Shot 2022-10-07 at 1.44.09 PM.png (862×1 px, 206 KB)

Screen Shot 2022-10-07 at 1.44.33 PM.png (849×1 px, 200 KB)

Screen Shot 2022-10-07 at 1.44.42 PM.png (846×1 px, 198 KB)

✅ AC2: No visual changes
No changes observed.