Page MenuHomePhabricator

Special:CheckUser paging links broken
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Load Special:CheckUser using 'get edits'
  • Try to use the limit paging links

What happens?:
The links do not use POST.

What should have happened instead?:
The links should have used POST and therefore worked.

Software version (skip for WMF-hosted wikis like Wikipedia):
Master branch of CheckUser

Other information (browser name/version, screenshots, etc.):

Below is the HTML generated for the paging links on Special:CheckUser (from a testing wiki where I could switch between wmf-1.26 and master for core)

beforeafter
image.png (122×1 px, 18 KB)
image.png (60×941 px, 4 KB)

Event Timeline

Change 830984 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Revert "Introduce PagerNavigationBuilder for making pagination links"

https://gerrit.wikimedia.org/r/830984

Change 830984 abandoned by Dreamy Jazz:

[mediawiki/core@master] Revert "Introduce PagerNavigationBuilder for making pagination links"

Reason:

Actually most of the change is fine. Could just instead fix the issue but reverting uses of the actual new method.

https://gerrit.wikimedia.org/r/830984

Change 830985 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Revert "Introduce PagerNavigationBuilder for making pagination links"

https://gerrit.wikimedia.org/r/830985

Either the paging links need to be disabled (not at all ideal as this is not an issue with CheckUser) or the change in core needs to be reverted before a new version of CheckUser can be released. Therefore marking as a 1.39 release blocker as 1.39 release is not far away.

Change 830985 abandoned by Dreamy Jazz:

[mediawiki/core@master] Revert "Introduce PagerNavigationBuilder for making pagination links"

Reason:

Should be fine to go with the patch that addresses the issue of not calling IndexPager::makeLink

https://gerrit.wikimedia.org/r/830985

Has been resolved in the parent task T317477. Have tested on enwiki and is all as working as before.