Migrate Translate extension away from use of PHPDOM's getElementsByTagName
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See parent task T317255: PHP's getElementsByTagName is slow prior to PHP 8.3 for justification and suggested replacements.

Details

	Subject	Repo	Branch	Lines +/-
	Use Zest's getElementsByTagName()	mediawiki/extensions/Translate	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T317255 PHP's getElementsByTagName is slow prior to PHP 8.3
		Resolved		Wangombe	T317523 Migrate Translate extension away from use of PHPDOM's getElementsByTagName

Event Timeline

Nikerabbit created this task.Sep 12 2022, 11:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2022, 11:04 AM

Nikerabbit triaged this task as Low priority.Sep 12 2022, 11:04 AM

Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-July-September) board.

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.

Nikerabbit added a parent task: T317255: PHP's getElementsByTagName is slow prior to PHP 8.3.

Nikerabbit set the point value for this task to 1.Sep 13 2022, 8:08 AM

Pginer-WMF edited projects, added Language-Team (Language-2022-October-December); removed Language-Team (Language-2022-July-September).Oct 3 2022, 3:07 PM

Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-October-December) board.

The only usage that I see of this is in XliffFFS::writeReal. This can be replace with \Wikimedia\Parsoid\Utils\DOMCompat::getElementsByTagName. Note that there are no tests for this class so we will have to be careful on how we test this.