Page MenuHomePhabricator
Create Task
Maniphest T317526

DomainException: HTMLForm::getField: no field named discussiontools-replytool
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   DomainException: HTMLForm::getField: no field named discussiontools-replytool
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLForm.php(444)
#0 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLFormField.php(145): HTMLForm->getField(string)
#1 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLFormField.php(160): HTMLFormField->getNearestField(string, boolean)
#2 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLFormField.php(277): HTMLFormField->getNearestFieldValue(array, string, boolean, boolean)
#3 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLFormField.php(265): HTMLFormField->checkStateRecurse(array, array)
#4 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLFormField.php(367): HTMLFormField->checkStateRecurse(array, array)
#5 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLForm.php(2068): HTMLFormField->isDisabled(array)
#6 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLForm.php(577): HTMLForm->loadFieldData()
#7 /srv/mediawiki/php-1.39.0-wmf.28/includes/htmlform/HTMLForm.php(629): HTMLForm->prepareForm()
#8 /srv/mediawiki/php-1.39.0-wmf.28/includes/specials/SpecialPreferences.php(121): HTMLForm->show()
#9 /srv/mediawiki/php-1.39.0-wmf.28/extensions/GlobalPreferences/includes/SpecialGlobalPreferences.php(31): SpecialPreferences->execute(NULL)
#10 /srv/mediawiki/php-1.39.0-wmf.28/includes/specialpage/SpecialPage.php(701): GlobalPreferences\SpecialGlobalPreferences->execute(NULL)
#11 /srv/mediawiki/php-1.39.0-wmf.28/includes/specialpage/SpecialPageFactory.php(1428): SpecialPage->run(NULL)
#12 /srv/mediawiki/php-1.39.0-wmf.28/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#13 /srv/mediawiki/php-1.39.0-wmf.28/includes/MediaWiki.php(904): MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.39.0-wmf.28/includes/MediaWiki.php(562): MediaWiki->main()
#15 /srv/mediawiki/php-1.39.0-wmf.28/index.php(50): MediaWiki->run()
#16 /srv/mediawiki/php-1.39.0-wmf.28/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Impact
Notes

Details

Request URL
https://ru.wikipedia.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:GlobalPreferences
SubjectRepoBranchLines +/-
PreferenceHooks: Avoid referring to the field of disabled featuremediawiki/extensions/DiscussionToolsREL1_39+4 -1
PreferenceHooks: Avoid referring to the field of disabled featuremediawiki/extensions/DiscussionToolsmaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheresNoTime created this task.Sep 12 2022, 11:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2022, 11:56 AM
TheresNoTime updated the task description. (Show Details)Sep 12 2022, 11:58 AM
TheresNoTime mentioned this in T317524: DomainException on Special:GlobalPreferences in ruwiki.Sep 12 2022, 12:02 PM
TheresNoTime added a subtask: T317524: DomainException on Special:GlobalPreferences in ruwiki.
TheresNoTime added a project: DiscussionTools.Sep 12 2022, 12:05 PM
gerritbot added a comment.Sep 12 2022, 12:45 PM

Change 831537 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/DiscussionTools@master] PreferenceHooks: Avoid refer to the field of disabled feature

https://gerrit.wikimedia.org/r/831537

gerritbot added a project: Patch-For-Review.Sep 12 2022, 12:45 PM
Iniquity added a comment.EditedSep 13 2022, 9:59 PM

I am sorry, but any progress here? We have a broken page that was linked from settings :(

ppelberg added a project: Editing-team (Kanban Board).Sep 22 2022, 3:21 PM
ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
gerritbot added a comment.Sep 24 2022, 11:30 PM

Change 831537 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] PreferenceHooks: Avoid referring to the field of disabled feature

https://gerrit.wikimedia.org/r/831537

matmarex subscribed.Sep 24 2022, 11:37 PM

The exception occurred if you had the Convenient Discussions gadget turned on, and was caused by code that disables the reply tool preference in that case (added in T298909).

Sorry, I was on vacation, and I guess the issue was uncommon enough that no one took notice sooner :(

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 24 2022, 11:38 PM
matmarex added a project: Editing QA.
gerritbot added a comment.Sep 24 2022, 11:40 PM

Change 834673 had a related patch set uploaded (by Zabe; author: Func):

[mediawiki/extensions/DiscussionTools@REL1_39] PreferenceHooks: Avoid referring to the field of disabled feature

https://gerrit.wikimedia.org/r/834673

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 25 2022, 12:00 AM
gerritbot added a comment.Sep 25 2022, 2:10 PM

Change 834673 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_39] PreferenceHooks: Avoid referring to the field of disabled feature

https://gerrit.wikimedia.org/r/834673

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2022, 2:30 PM
EAkinloose edited projects, added Verified; removed Editing QA.Sep 26 2022, 5:55 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Umherirrender closed this task as Resolved.Oct 4 2022, 6:53 PM
Umherirrender assigned this task to Func.
ppelberg closed subtask T317524: DomainException on Special:GlobalPreferences in ruwiki as Resolved.Oct 18 2022, 12:40 AM
Krinkle moved this task from Untriaged to Sep 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits