Page MenuHomePhabricator

MediaWiki should respect no_proxy environment setting
Open, MediumPublic

Description

Simple function for parsing no_proxy

MediaWiki uses getenv('http_proxy') in HttpFunctions.php, but does not respect no_proxy environment variable. This is incorrect, because probably if MediaWiki sits behind proxy, then there is also some intranet area, accessible without proxy and probably INaccessible through proxy. :)
I suggest using the attached function for this (we use it in Mediawiki4Intranet).


Version: 1.20.x
Severity: normal

Attached:

Details

Reference
bz29755

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:32 PM
bzimport set Reference to bz29755.
bzimport added a subscriber: Unknown Object (MLST).

r91642 Closing this, but would you mind submitting some unit tests for your code fragment?

Was reverted in r91738 -- apparently this code has some sort of problems.

Also -- please ask for tests BEFORE committing, Mark!