Page MenuHomePhabricator
Create Task
Maniphest T317594

Block translations by users who have been blocked from editing a translatable bundle
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

If a user is blocked from translating a translatable page or message bundle, they should not be able to be allowed to submit translations for it.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Translation permission: Return message key and paramsmediawiki/extensions/Translatemaster+2 -1
Block translations from user blocked from editing translatable bundlemediawiki/extensions/Translatemaster+41 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Sep 13 2022, 2:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2022, 2:28 AM
abi_ moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-July-September) board.Sep 13 2022, 2:28 AM
gerritbot added a comment.Sep 13 2022, 4:27 AM

Change 831651 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] BLock translations from user blocked from editing translatable bundle

https://gerrit.wikimedia.org/r/831651

gerritbot added a project: Patch-For-Review.Sep 13 2022, 4:27 AM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-July-September) board.Sep 13 2022, 5:03 AM
abi_ moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Sep 14 2022, 6:57 AM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2022-July-September) board.Sep 26 2022, 12:54 PM
gerritbot added a comment.Sep 26 2022, 12:56 PM

Change 831651 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Block translations from user blocked from editing translatable bundle

https://gerrit.wikimedia.org/r/831651

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 26 2022, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 26 2022, 1:32 PM
Pginer-WMF edited projects, added Language-Team (Language-2022-October-December); removed Language-Team (Language-2022-July-September).Oct 3 2022, 3:04 PM
Pginer-WMF moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2022-October-December) board.
abi_ closed this task as Resolved.Oct 4 2022, 4:28 AM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2022-October-December) board.

Tested on translatewiki.net:

image.png (651×1 px, 71 KB)

Tacsipacsi subscribed.Oct 4 2022, 3:29 PM

The angle brackets ⧼⧽ shouldn’t be there, it looks like the wrapper message tries to treat the whole block message as a message key.

Nikerabbit reopened this task as Open.Oct 5 2022, 6:55 AM
Nikerabbit moved this task from Done to Priority: Localization infrastructure on the Language-Team (Language-2022-October-December) board.
abi_ mentioned this in T320612: (Globally) blocked IP address has no permission to access "Translations" namespace (NS1198).Oct 12 2022, 2:19 PM
Nikerabbit added a subtask: T320612: (Globally) blocked IP address has no permission to access "Translations" namespace (NS1198).Oct 27 2022, 8:23 AM
gerritbot added a comment.Oct 28 2022, 8:14 AM

Change 850410 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Translation permission: Return message key and params

https://gerrit.wikimedia.org/r/850410

gerritbot added a project: Patch-For-Review.Oct 28 2022, 8:14 AM
abi_ added a comment.Oct 28 2022, 8:25 AM
In T317594#8351849, @gerritbot wrote:

Change 850410 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Translation permission: Return message key and params

https://gerrit.wikimedia.org/r/850410

With this patch, we now have this displayed:

image.png (438×1 px, 30 KB)

abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2022-October-December) board.Oct 28 2022, 8:29 AM
gerritbot added a comment.Oct 31 2022, 3:27 PM

Change 850410 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Translation permission: Return message key and params

https://gerrit.wikimedia.org/r/850410

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2022, 3:30 PM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2022-October-December) board.Oct 31 2022, 3:51 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Oct 31 2022, 4:00 PM
abi_ closed this task as Resolved.Nov 2 2022, 11:23 AM
abi_ closed subtask T320612: (Globally) blocked IP address has no permission to access "Translations" namespace (NS1198) as Resolved.
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2022-October-December) board.

Tested on test.wikipedia.org:

image.png (473×928 px, 31 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits