Page MenuHomePhabricator
Create Task
Maniphest T317710

Consider allowing icons with color (wikilove and watchstar)
Closed, DeclinedPublic
Actions

Assigned To
None
Authored By
Jdlrobson
Sep 13 2022, 8:43 PM
Tags
Referenced Files
F36845812: Captura de Pantalla 2023-02-15 a las 13.09.02.png
Feb 15 2023, 12:10 PM
F35781730: watchstar.webm
Nov 15 2022, 2:54 PM
F35754321: watchstar_not_updating.png
Nov 11 2022, 2:01 PM
F35519579: image.png
Sep 13 2022, 8:43 PM
F35519578: image.png
Sep 13 2022, 8:43 PM
Subscribers
Aklapper
• alexhollender_WMF
bmartinezcalvo
dom_walden
Jdlrobson
Ladsgroup
ovasileva
View All 9 Subscribers

Description

In T234990 we replaced Vector's legacy icons with Wikimedia UI equivalents.

Before:

image.png (211×1 px, 44 KB)

After:

image.png (204×706 px, 21 KB)

Replicate on https://en.wikipedia.beta.wmflabs.org/wiki/User:JDrewniak?vectorvisualenhancementnext=1 while logged in.

The question was raised about whether the Wikilove icon should be red. Currently such a state does not seem possible from a technical point of view.

This task is about deciding whether we want to restore the old color, and if so working out how to do that technically.

Acceptance criteria

  • Make a decision whether Wikilove icon should be filled
  • Make a decision whether Watchstar icon should be filled
  • The watchstar on mobile and desktop should be the same color when filled (T234550)

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 13 2022, 8:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2022, 8:43 PM
Jdlrobson mentioned this in T234990: Replace 'watchstar' and 'wikilove' icon with WikimediaUI default.Sep 13 2022, 8:44 PM
• alexhollender_WMF added a comment.Sep 14 2022, 12:01 AM

@Jdlrobson do we also want to include the question of whether the watchstar should be blue when you're watching a page (as it is on mobile)?

Jdlrobson added a comment.Sep 14 2022, 12:08 AM

Yes. That's in the list of things to do.

dom_walden subscribed.Nov 11 2022, 2:01 PM

I am finding on User_talk pages when I watch or unwatch, the star is not automatically updated (to be filled or empty as appropriate). Should I raise this as a separate bug?

For example, try clicking the star on one of these pages:

watchstar_not_updating.png (238×650 px, 17 KB)

Jdlrobson mentioned this in T322673: Test VectorVisualEnhancementsNext flag.Nov 14 2022, 9:37 PM
• alexhollender_WMF added a comment.Nov 15 2022, 2:54 PM

@dom_walden I am not seeing that bug. can you include a screen recording?

dom_walden added a comment.Nov 15 2022, 4:04 PM
In T317710#8396183, @alexhollender_WMF wrote:

@dom_walden I am not seeing that bug. can you include a screen recording?

The bug has now been fixed T322673#8394255.

Ladsgroup subscribed.Dec 12 2022, 4:35 AM

I suggested to change color of wikilvoe to red but honestly now I take it back, Reading a bit on color theory, it makes much more sense to avoid adding new colors as much as possible. This goes for the watch icon too (but maybe it would fit under 30 in the 60-30-10 rule though?)

Jdlrobson added a project: Web-Team-Backlog.Feb 14 2023, 10:48 PM

@alexhollender_WMF should this ticket be declined?

• alexhollender_WMF added subscribers: bmartinezcalvo, Sarai-WMDE.Feb 14 2023, 11:09 PM
In T317710#8616686, @Jdlrobson wrote:

@alexhollender_WMF should this ticket be declined?

@bmartinezcalvo @Sarai-WMDE what do you think about this task? using red for the active state of the wikilove icon button is something we did in Legacy Vector, and currently on mobile/minerva the active state for the watchstar is blue.

bmartinezcalvo added a comment.EditedFeb 15 2023, 12:06 PM
In T317710#8616759, @alexhollender_WMF wrote:

@bmartinezcalvo @Sarai-WMDE what do you think about this task? using red for the active state of the wikilove icon button is something we did in Legacy Vector, and currently on mobile/minerva the active state for the watchstar is blue.

@alexhollender_WMF red color is used just as destructive or error state in our color tokens, so I would not use it to paint the selected heart icon. I would use color-progressive--active instead to paint the selected watchlist and heart icons.

Apart from this, since we are using a selectable quiet button, it might make sense to use a Toggled Quiet Button instead:

Captura de Pantalla 2023-02-15 a las 13.09.02.png (432×1 px, 158 KB)

Jdlrobson updated the task description. (Show Details)Feb 15 2023, 6:16 PM
Jdlrobson added a subtask: T234550: Mobile version Star for Watchlist not consistent with desktop (blue fill vs black fill).
Krinkle attached a referenced file: F36845812: Captura de Pantalla 2023-02-15 a las 13.09.02.png. (Show Details)Feb 15 2023, 8:30 PM
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Feb 22 2023, 9:34 PM
ovasileva closed this task as Declined.Mar 1 2023, 11:14 PM
ovasileva subscribed.

Seems like we might not want to do this? Declining, but feel free to reopen in case I'm interpreting the comments incorrectly

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL