Page MenuHomePhabricator

Ensure the Add Topic button and language menu appear in the same order on Wikipedia namespace pages
Closed, ResolvedPublic

Description

Description

On certain pages, like Village Pump page and Administrator noticeboard, the Add topic button and the language menu (will soon) appear in both the page titlebar and the sticky header[i]. This ticket involves the work with ensuring that the Add topic and language selection buttons will appear in the same order in both places.

Behavior

CurrentExpected
Above page tools toolbar
image.png (250×1 px, 107 KB)
(same as current)
Sticky header
image.png (428×1 px, 134 KB)
image.png (428×1 px, 140 KB)

Note: the scope of this task used to include Talk pages, but given T316559#8352067 that scope has been removed from this task.


i. See T267444


Thank you to @Whatamidoing-WMF for spotting this behavior.

Example page: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&useskin=vector-2022

Event Timeline

Related: I believe T316559 includes Talk pages, so after that work is done the language button on talk pages would look more or less like this:

image.png (1×2 px, 413 KB)

@Pginer-WMF can you confirm that?

@Pginer-WMF can you confirm that?

It is correct. Pages where language switching/adding is not allowed will get a more minimal treatment (without label) to communicate so and still allow access to other language settings. What is not covered in T316559 is the order in which the language icon will be shown with respect to other actions such as "add topic".

ovasileva triaged this task as Medium priority.Sep 20 2022, 8:17 AM

right, good point. So to re-cap: even if Pau says we can remove the language menu from the sticky header on Talk pages (which I've asked him about here), we will still need to ensure the consistency of the positions of Add topic and the language menu because they will both appear in the sticky header on certain :Wikipedia namespace pages (e.g. the Village Pump page and Administrator noticeboard)

@ppelberg @ovasileva per T316559#8352067 we can remove the language menu from the sticky header on Talk pages. Should I setup a separate task for that, and if so please let me know which board/team it should belong to.

alexhollender_WMF renamed this task from Ensure the Add Topic button and language selector appear in the same order on talk pages to Ensure the Add Topic button and language menu appear in the same order on Wikipedia namespace pages.Oct 28 2022, 12:36 PM
alexhollender_WMF updated the task description. (Show Details)

@ppelberg @ovasileva per T316559#8352067 we can remove the language menu from the sticky header on Talk pages. Should I setup a separate task for that, and if so please let me know which board/team it should belong to.

This is happening in T322153 now.

Change 902512 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Fix order of language menu and add topic in sticky header

https://gerrit.wikimedia.org/r/902512

It looks like we noticed and failed to fix this issue three or four times now ;)

Change 902512 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix order of language menu and add topic in sticky header

https://gerrit.wikimedia.org/r/902512

Is this fixed now? Or is it still going through QA?

It is fixed and awaiting QA approval.

EAkinloose subscribed.

✅ Add Topic button and language menu appear in the same order

Wikipedia

Screenshot 2023-04-21 at 23.33.08.png (742×2 px, 229 KB)

Screenshot 2023-04-21 at 23.33.24.png (740×3 px, 264 KB)

Template

Screenshot 2023-04-21 at 23.34.54.png (610×3 px, 261 KB)

Screenshot 2023-04-21 at 23.35.09.png (768×2 px, 250 KB)

Editor

Screenshot 2023-04-21 at 23.35.32.png (742×2 px, 396 KB)

Screenshot 2023-04-21 at 23.35.48.png (738×2 px, 292 KB)

EAkinloose claimed this task.