Page MenuHomePhabricator

☕️ Combine mocha tests for long and short statement edit routes
Closed, ResolvedPublic

Description

We decided this is nice because:

  • they're almost identical and combining them makes the difference nicely visible
  • combining them should be slightly faster (same number of tests but initial setup runs only once)
  • less likely to forget the other route when making changes

On the negative side, it might make the tests a little bit harder to read, especially with regards to the execution order in mocha suites.

Event Timeline

Change 833339 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Make test file names consistent

https://gerrit.wikimedia.org/r/833339

Change 833339 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make test file names consistent

https://gerrit.wikimedia.org/r/833339