🥑️ Create a `FormatableSummaryAdapter`
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ollie.Shotton_WMDE
	Sep 14 2022, 3:04 PM

Description

Create a FormatableSummaryAdapter which translates from our EditSummary to a FormatableSummary:

map the EditSummary::getEditAction() to a FormatableSummary with the module name (wbsetclaim or wbremoveclaims) and action name (create, update, remove)
get the property id and mainsnak from StatementEditSummary::getStatement()

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
REST: Combine edit summary conversion and formatting	mediawiki/extensions/Wikibase	master	+22 -10
REST: Fix FormatableSummaryConverterTest	mediawiki/extensions/Wikibase	master	+1 -2
REST: Add FormatableSummaryConverter	mediawiki/extensions/Wikibase	master	+139 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T335067 Epic: Wikidata Query Service stabilization
Resolved	Lydia_Pintscher	T314503 rollout of the new Wikibase REST API to Wikidata
Invalid	None	T301860 Enable reading and modifying a statement of item or property using REST API
Invalid	None	T301861 Authenticate as mediawiki user when making write operations to a stement using REST API
Resolved	WMDE-leszek	T306917 Request data of a single statement of an item
Resolved	WMDE-leszek	T307088 🟦️ Create an initial implementation of GET /entities/items/{item_id}/statements/{statement_id}
Resolved	WMDE-leszek	T308426 🟦️ Return error response in `GetItemStatement` use case when item does not exist
Resolved	WMDE-leszek	T308427 🟦️ Create schema tests for GET /entities/items/{item_id}/statements/{statement_id}
Resolved	WMDE-leszek	T308515 🟦️ Create route handler for GET /entities/items/{item_id}/statements/{statement_id}
Resolved	WMDE-leszek	T308516 🟦️ Add spec for GET /entities/items/{item_id}/statements/{statement_id}
Resolved	WMDE-leszek	T308517 🟦️ Change GetItemStatement to work with a combination of item id + statement id
Resolved	WMDE-leszek	T309020 🟦️ Respond with statement not found if item exists but statement id does not match item id
Resolved	WMDE-leszek	T307087 🟧 Create an initial implementation of GET /statements/{statement_id}
Resolved	Ollie.Shotton_WMDE	T307223 🟧 Create Use Case and Data Access Service interface for GET /statements/{statement_id}
Resolved	WMDE-leszek	T307225 🟧 Add endpoint section for GET /statements/{statement_id} to the OpenAPI specification
Resolved	WMDE-leszek	T307227 🟧️🟪️ Create a service to retrieve item revision metadata
Resolved	Jakob_WMDE	T307226 🟧 Respond with 500 error response in case of unexpected errors for GET /statements/{statement_id}
Resolved	WMDE-leszek	T307228 🟧 Schema tests for GET /statements/{statement_id}
Resolved	WMDE-leszek	T307230 🟧 Respond with 404 if the Statement was not found
Resolved	Ollie.Shotton_WMDE	T307238 🟧 Create GetStatementRouteHandler
Resolved	Ollie.Shotton_WMDE	T307239 🟧 Respond with 400 status code in case of an invalid statement id
Resolved	Jakob_WMDE	T307031 🟩️ Conditionally request the data of statements of an item
Resolved	Jakob_WMDE	T309680 🟩️ Add a 304 spec test for statements of an item
Resolved	WMDE-leszek	T307032 🟪️ Conditionally request the data of an item statement
Resolved	Silvan_WMDE	T309513 🟪️ Add header parameters to the OpenAPI spec
Resolved	Silvan_WMDE	T309514 🟪️ Implement conditional requests for single statement
Resolved	Silvan_WMDE	T309515 🟪️ Implement conditional requests for item specific single statement
Resolved	Silvan_WMDE	T309516 🟪️ Add 304 spec tests for single statement and item specific single statement
Resolved	WMDE-leszek	T309846 🟦️ Authenticate and authorize as mediawiki user when creating statement using POST /entities/items/{item_id}/statements
Resolved	Jakob_WMDE	T311154 🟦️ Implement REST API specific PermissionChecker
Resolved	Jakob_WMDE	T311200 🟦️ Authorization prerequisites
Resolved	Silvan_WMDE	T311221 🟦️ Use the newly created `PermissionChecker` in the AddItemStatement use case
Resolved	None	T312748 🟦️ Authenticate and authorize as mediawiki user when making DELETE and PUT requests to REST API statement routes
Resolved	Jakob_WMDE	T314031 🟦️ Check authorization for PUT statement requests
Resolved	Ollie.Shotton_WMDE	T314033 🟦️ Check authorization for DELETE statement requests
Resolved	Silvan_WMDE	T312750 🟪️ Do not use a placeholder edit summary/comment when none provided by the client
Resolved	WMDE-leszek	T312811 🥑️ Provide initial "automated summaries" to statement edits made with Wikibase REST API
Resolved	Jakob_WMDE	T317774 🥑️ Create a `FormatableSummaryAdapter`
Resolved	WMDE-leszek	T321459 🌯️ Adjust statement data structure in Wikibase REST API responses and requests
Resolved	Jakob_WMDE	T322650 🌯️ Create Deserializers to read adjusted statement data structure
Resolved	Ollie.Shotton_WMDE	T322653 🌯️ Use new Deserializers in Wikibase REST API requests
Resolved	Ollie.Shotton_WMDE	T322655 🌯️ Cleanup after statement data structure change
Resolved	Ollie.Shotton_WMDE	T322660 🌯️ Adjust OpenAPI definition for the new statement format
Resolved	Jakob_WMDE	T322661 🌯️ Create serializers for the new statement format
Resolved	Silvan_WMDE	T322737 🌯️ Use new Serializers in Wikibase REST API responses
Resolved	Silvan_WMDE	T322831 🌯️ Document differences between the new statement structure and the old one