Page MenuHomePhabricator
Create Task
Maniphest T317779

đŸĨ‘ī¸ Include auto summary data in `EditMetadata`
Closed, ResolvedPublic
Actions

Description

  • create an EditSummary interface and implement it in a StatementEditSummary class
    • EditSummary has two methods public function getUserComment(): ?string and public function getEditAction(): string and constants for all kinds of edit actions
    • StatementEditSummary has factory methods for all actions, and a public function getStatement(): Statement method
  • change EditMetadata
    • remove the getComment method
    • add a getSummary method which returns an EditSummary object

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
REST: Add EditSummary to EditMetadataOllie Shottonmediawiki/extensions/Wikibasemaster+188 -86
REST: Create and implement EditSummary interfaceOllie Shottonmediawiki/extensions/Wikibasemaster+83 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT335067 Epic: Wikidata Query Service stabilization
 ResolvedLydia_PintscherT314503 rollout of the new Wikibase REST API to Wikidata
 InvalidNoneT301860 Enable reading and modifying a statement of item or property using REST API
 InvalidNoneT301861 Authenticate as mediawiki user when making write operations to a stement using REST API
 ResolvedWMDE-leszekT306917 Request data of a single statement of an item
 ResolvedWMDE-leszekT307088 đŸŸĻī¸ Create an initial implementation of GET /entities/items/{item_id}/statements/{statement_id}
 ResolvedWMDE-leszekT308426 đŸŸĻī¸ Return error response in `GetItemStatement` use case when item does not exist
 ResolvedWMDE-leszekT308427 đŸŸĻī¸ Create schema tests for GET /entities/items/{item_id}/statements/{statement_id}
 ResolvedWMDE-leszekT308515 đŸŸĻī¸ Create route handler for GET /entities/items/{item_id}/statements/{statement_id}
 ResolvedWMDE-leszekT308516 đŸŸĻī¸ Add spec for GET /entities/items/{item_id}/statements/{statement_id}
 ResolvedWMDE-leszekT308517 đŸŸĻī¸ Change GetItemStatement to work with a combination of item id + statement id
 ResolvedWMDE-leszekT309020 đŸŸĻī¸ Respond with statement not found if item exists but statement id does not match item id
 ResolvedWMDE-leszekT307087 🟧 Create an initial implementation of GET /statements/{statement_id}
 ResolvedOllie.Shotton_WMDET307223 🟧 Create Use Case and Data Access Service interface for GET /statements/{statement_id}
 ResolvedWMDE-leszekT307225 🟧 Add endpoint section for GET /statements/{statement_id} to the OpenAPI specification
 ResolvedWMDE-leszekT307227 🟧ī¸đŸŸĒī¸ Create a service to retrieve item revision metadata
 ResolvedJakob_WMDET307226 🟧 Respond with 500 error response in case of unexpected errors for GET /statements/{statement_id}
 ResolvedWMDE-leszekT307228 🟧 Schema tests for GET /statements/{statement_id}
 ResolvedWMDE-leszekT307230 🟧 Respond with 404 if the Statement was not found
 ResolvedOllie.Shotton_WMDET307238 🟧 Create GetStatementRouteHandler
ResolvedOllie.Shotton_WMDET307239 🟧 Respond with 400 status code in case of an invalid statement id
 ResolvedJakob_WMDET307031 🟩ī¸ Conditionally request the data of statements of an item
 ResolvedJakob_WMDET309680 🟩ī¸ Add a 304 spec test for statements of an item
 ResolvedWMDE-leszekT307032 đŸŸĒī¸ Conditionally request the data of an item statement
 ResolvedSilvan_WMDET309513 đŸŸĒī¸ Add header parameters to the OpenAPI spec
 ResolvedSilvan_WMDET309514 đŸŸĒī¸ Implement conditional requests for single statement
 ResolvedSilvan_WMDET309515 đŸŸĒī¸ Implement conditional requests for item specific single statement
 ResolvedSilvan_WMDET309516 đŸŸĒī¸ Add 304 spec tests for single statement and item specific single statement
 ResolvedWMDE-leszekT309846 đŸŸĻī¸ Authenticate and authorize as mediawiki user when creating statement using POST /entities/items/{item_id}/statements
 ResolvedJakob_WMDET311154 đŸŸĻī¸ Implement REST API specific PermissionChecker
 ResolvedJakob_WMDET311200 đŸŸĻī¸ Authorization prerequisites
 ResolvedSilvan_WMDET311221 đŸŸĻī¸ Use the newly created `PermissionChecker` in the AddItemStatement use case
 ResolvedNoneT312748 đŸŸĻī¸ Authenticate and authorize as mediawiki user when making DELETE and PUT requests to REST API statement routes
 ResolvedJakob_WMDET314031 đŸŸĻī¸ Check authorization for PUT statement requests
 ResolvedOllie.Shotton_WMDET314033 đŸŸĻī¸ Check authorization for DELETE statement requests
 ResolvedSilvan_WMDET312750 đŸŸĒī¸ Do not use a placeholder edit summary/comment when none provided by the client
 ResolvedWMDE-leszekT312811 đŸĨ‘ī¸ Provide initial "automated summaries" to statement edits made with Wikibase REST API
 ResolvedOllie.Shotton_WMDET317779 đŸĨ‘ī¸ Include auto summary data in `EditMetadata`
 ResolvedWMDE-leszekT321459 đŸŒ¯ī¸ Adjust statement data structure in Wikibase REST API responses and requests
 ResolvedJakob_WMDET322650 đŸŒ¯ī¸ Create Deserializers to read adjusted statement data structure
 ResolvedOllie.Shotton_WMDET322653 đŸŒ¯ī¸ Use new Deserializers in Wikibase REST API requests
 ResolvedOllie.Shotton_WMDET322655 đŸŒ¯ī¸ Cleanup after statement data structure change
 ResolvedOllie.Shotton_WMDET322660 đŸŒ¯ī¸ Adjust OpenAPI definition for the new statement format
 ResolvedJakob_WMDET322661 đŸŒ¯ī¸ Create serializers for the new statement format
 ResolvedSilvan_WMDET322737 đŸŒ¯ī¸ Use new Serializers in Wikibase REST API responses
 ResolvedSilvan_WMDET322831 đŸŒ¯ī¸ Document differences between the new statement structure and the old one

Event Timeline

Jakob_WMDE created this task.Sep 14 2022, 3:08 PM
Restricted Application added a subscriber: â€ĸ Aklapper. ¡ View Herald TranscriptSep 14 2022, 3:08 PM
Ollie.Shotton_WMDE claimed this task.Sep 14 2022, 3:38 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 13) board.
gerritbot added a comment.Sep 14 2022, 5:26 PM

Change 832298 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Create and implement EditSummary interface

https://gerrit.wikimedia.org/r/832298

gerritbot added a project: Patch-For-Review.Sep 14 2022, 5:26 PM

Change 832299 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Add EditSummary to EditMetadata

https://gerrit.wikimedia.org/r/832299

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 13) board.Sep 14 2022, 5:49 PM
gerritbot added a comment.Sep 15 2022, 7:53 AM

Change 832298 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Create and implement EditSummary interface

https://gerrit.wikimedia.org/r/832298

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 15 2022, 8:00 AM
gerritbot added a comment.Sep 16 2022, 8:03 AM

Change 832299 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add EditSummary to EditMetadata

https://gerrit.wikimedia.org/r/832299

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 13) board.Sep 16 2022, 8:08 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 16 2022, 8:30 AM
WMDE-leszek closed this task as Resolved.Oct 14 2022, 12:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. ¡ Wikimedia Foundation ¡ Privacy Policy ¡ Code of Conduct ¡ Terms of Use ¡ Disclaimer ¡ CC-BY-SA ¡ GPL ¡ Credits