Page MenuHomePhabricator

[M] [Regression] Vector 2022 should display a "log in" link on private wikis
Closed, ResolvedPublic1 Estimated Story Points

Description

Problem

Legacy Vector displays a "log in" link in the header (next to the language button) on private wikis e.g.

Vector 2022 however, does not show the log in link because it's inside the user-menu dropdown (which is unavailable because the wikis are not publicly editable).

Expected behaviour

Vector 2022 should show the log in link on wikis even if they are not publicly editable.

QA Steps

  1. Visit https://office.wikimedia.org/ anonymously
  2. Ensure that the user menu button appears and shows a log in link as a menu item
  1. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page anonymously
  2. Ensure that the user menu button appears and shows a log in link as a menu item

QA Results - Beta

ACStatusDetails
1T317789#8360518

QA Results - Prod

ACStatusDetails
1T317789#8360525

Event Timeline

ovasileva renamed this task from Vector 2022 should display a "log in" link on private wikis to [Regression] Vector 2022 should display a "log in" link on private wikis.Sep 15 2022, 9:15 AM
ovasileva triaged this task as High priority.

Looks like the .emptyPortlet class is incorrectly being added to the #p-personal element. Perhaps that class should always be removed in our modifications to the menu?

I believe the .emptyPortlet class is being applied because the anon contributions and anon talk links arent on OfficeWiki, and the rest of the elements in the user menu dropdown are manually added via html-before-portal in SkinVector::getUserLinksTemplateData.

The menu looks like this when .emptyPortlet is removed
{F35528677}

Since the "Pages for logged out editors" div is intended to label the anon contributions and talk links, it might make sense to avoid removing the emptyPortlet class and instead use it to hide the "Pages for logged out editors" text.

Change 834385 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Fix Vector 2022 missing anon user menu for private wikis

https://gerrit.wikimedia.org/r/834385

nray subscribed.

Change 835281 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] [Quick Fix] Fix Vector 2022 should display a "log in" link on private wikis

https://gerrit.wikimedia.org/r/835281

As discussed in standup today, if we are looking to quickly fix this issue https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/835281 might be a viable option as it adds a minimal amount of css that should be easy to clean up once a better solution has been determined. In the meantime, I'm doing more analysis of the current code to determine the best and more long-term solution for this

Change 834385 abandoned by Nray:

[mediawiki/skins/Vector@master] Fix Vector 2022 missing anon user menu for private wikis

Reason:

taking a different approach

https://gerrit.wikimedia.org/r/834385

Change 835281 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Quick Fix] Fix Vector 2022 should display a "log in" link on private wikis

https://gerrit.wikimedia.org/r/835281

Change 837167 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Fix login link bug by introducing MenuDropdown and MenuGroup components

https://gerrit.wikimedia.org/r/837167

We talked about this yesterday in standup and decided to go with the short-term fix and that will go out with next week's train. We'll look to address the bigger issue here next week.

Change 837188 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Remove $isDropdownItem param from SkinVector::getCreateAccountHTML

https://gerrit.wikimedia.org/r/837188

LGoto renamed this task from [Regression] Vector 2022 should display a "log in" link on private wikis to [M] [Regression] Vector 2022 should display a "log in" link on private wikis.Oct 3 2022, 5:33 PM
LGoto changed the point value for this task from 3 to 1.

Change 837167 abandoned by Nray:

[mediawiki/skins/Vector@master] POC: User menu with MenuDropdown and MenuGroup components

Reason:

POC that I think we should consider especially when we implement article tools

https://gerrit.wikimedia.org/r/837167

Change 837188 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove $isDropdownItem param from SkinVector::getCreateAccountHTML

https://gerrit.wikimedia.org/r/837188

My bad for missing this, there are still two patches left for review and I will get to them today

Change 837744 had a related patch set uploaded (by Bernard Wang; author: Nray):

[mediawiki/skins/Vector@master] Fix Vector 22 missing user menu on private wikis

https://gerrit.wikimedia.org/r/837744

Change 837744 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix Vector 22 missing user menu on private wikis

https://gerrit.wikimedia.org/r/837744

I'm moving this to blocked as there is one patch remaining on this to remove the temporary CSS (https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/838186), but that should only be merged no earlier than Tuesday, October 25 to avoid caching issues

nray claimed this task.

Change 845737 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/core@master] Convert SkinComponentMenu `is-empty` from string to boolean

https://gerrit.wikimedia.org/r/845737

Change 845737 merged by jenkins-bot:

[mediawiki/core@master] Convert SkinComponentMenu `is-empty` from string to boolean

https://gerrit.wikimedia.org/r/845737

This comment was removed by nray.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page anonymously
Ensure that the user menu button appears and shows a log in link as a menu item

Screen Shot 2022-10-25 at 5.16.23 PM.png (263×1 px, 52 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: officewiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://office.wikimedia.org/ anonymously
Ensure that the user menu button appears and shows a log in link as a menu item
{F35627841}

Change 863364 had a related patch set uploaded (by Func; author: Nray):

[mediawiki/skins/Vector@REL1_39] Fix Vector 22 missing user menu on private wikis

https://gerrit.wikimedia.org/r/863364

Change 863364 merged by jenkins-bot:

[mediawiki/skins/Vector@REL1_39] Fix Vector 22 missing user menu on private wikis

https://gerrit.wikimedia.org/r/863364