Maniphest T317791

Remove the BaseTemplate::getFooterIcons method
Closed, ResolvedPublic
Actions

Description

Maintaining code that is never used in production is not in our interest.

In T278266 we cleaned up most usages of BaseTemplate::getFooterIcons. We'd now like to remove the code.

TODO

Alert all remaining extensions/skins about the upcoming breaking change (https://codesearch.wmcloud.org/search/?q=-%3EgetFooterIcons%5C(&i=nope&files=&excludeFiles=&repos=) . Note: some of these repos are unmaintained. Push patches where easy to setup extension/skin.
Remove code in MediaWIki core
Make sure to update RELEASE_NOTES to document the removal.

Migration notes

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove BaseTemplate::getFooterIcons	mediawiki/core	master	+4 -35

Customize query in gerrit

Related Objects

Mentioned In: T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead
Mentioned Here: T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead

Event Timeline

Jdlrobson created this task.Sep 14 2022, 5:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2022, 5:18 PM

Jdlrobson moved this task from Backlog to Deprecations/removals on the MediaWiki-Core-Skin-Architecture board.Sep 14 2022, 5:18 PM

Jdlrobson mentioned this in T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.Sep 14 2022, 5:32 PM

Reedy moved this task from Blocker to To deprecate or remove on the MW-1.40-release board.Oct 26 2022, 3:55 PM

Jdlrobson triaged this task as High priority.Feb 23 2023, 5:30 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: patch-welcome.

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added MW-1.41-release; removed MW-1.40-release.Jun 14 2023, 9:22 PM

Reedy moved this task from Blocker to To deprecate or remove on the MW-1.41-release board.Aug 26 2023, 6:32 PM

Jdforrester-WMF added a project: Technical-Debt (Deprecation process).Sep 22 2023, 5:21 PM

Note that these have missed the boat for 1.41, so should be moved/re-evaluated for 1.42.

Jdlrobson edited projects, added MW-1.42-release; removed MW-1.41-release.Dec 21 2023, 7:03 PM

Jdforrester-WMF moved this task from Blocker to Deprecate or remove on the MW-1.42-release board.Jan 3 2024, 5:51 PM

Krinkle moved this task from Untriaged to 2023+ | MW 1.40+ on the Technical-Debt (Deprecation process) board.Mar 27 2024, 6:43 PM

Jdlrobson added a project: Web-Team-Housekeeping.Dec 11 2024, 4:24 PM

Jdlrobson edited projects, added MW-1.44-release; removed MW-1.42-release.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Backlog to Remove unsupported code paths on the Web-Team-Housekeeping board.Dec 11 2024, 6:04 PM

Atieno added a parent task: T390686: Release MediaWiki 1.44.0.Apr 1 2025, 11:54 AM

I think this is just a deprecation task and not a blocker?

Aklapper removed a parent task: T390686: Release MediaWiki 1.44.0.Apr 1 2025, 12:41 PM

MSantos moved this task from Blocker to Deprecate or remove on the MW-1.44-release board.Apr 1 2025, 1:17 PM

Change #1138414 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove BaseTemplate::getFooterIcons

https://gerrit.wikimedia.org/r/1138414

gerritbot added a project: Patch-For-Review.Apr 23 2025, 5:02 PM

Change #1138414 merged by jenkins-bot:

[mediawiki/core@master] Remove BaseTemplate::getFooterIcons

https://gerrit.wikimedia.org/r/1138414

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2025, 5:30 PM

Jdlrobson-WMF closed this task as Resolved.Apr 25 2025, 5:33 PM

Jdlrobson-WMF updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Apr 25 2025, 6:00 PM