@KStoller-WMF perhaps we should put the success message just above drawer, like we do on mobile?

Otherwise, we could use position: fixed on desktop to pin the toast message towards the top of the viewport.

As a side note, do you all remember if there is supposed to be a "Close and edit again" prompt in this dialog?

In T317819#8238726, @kostajh wrote:

As a side note, do you all remember if there is supposed to be a "Close and edit again" prompt in this dialog?

It was removed in favor of a collapse icon in T301603: Newcomer tasks: increased flexibility at post-edit dialog.

In T317819#8238726, @kostajh wrote:

@KStoller-WMF perhaps we should put the success message just above drawer, like we do on mobile?

That makes sense to me. Placing the confirmation message there also helps draw attention to the "Edit another suggestion" call to action, which could funnel more people into trying another suggested edit.

@KieranMcCann Does this approach sound OK to you, or do you have any concerns with this change?

@KStoller-WMF Yes I’m happy with that approach. I think it makes sense for the two messages to be in the same vicinity of each other on the screen.

Change 888763 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Post edit: show the success toast message tied to the drawer

https://gerrit.wikimedia.org/r/888763

FWIW the old behavior was added in T301603: Newcomer tasks: increased flexibility at post-edit dialog, on the basis that it is more engaging/noticeable. I wouldn't mind getting rid of it (IMO it was one of those UX flourishes where the improvement wasn't really proportional with the code complexity it required), but we could probably fix it just by changing the positioning from absolute to fixed.

In T317819#8617279, @Tgr wrote:

FWIW the old behavior was added in T301603: Newcomer tasks: increased flexibility at post-edit dialog, on the basis that it is more engaging/noticeable. I wouldn't mind getting rid of it (IMO it was one of those UX flourishes where the improvement wasn't really proportional with the code complexity it required), but we could probably fix it just by changing the positioning from absolute to fixed.

I agree. Tying the apparition of the message to the apparition of the drawer in both positioning and timing seems conceptually incorrect because the message is the feedback from a successful save. If the drawer breaks for any reason we would probably fail to show an edit success message which seems critical for a newcomer. Also if we wanted to stop showing the post edit drawer for any reason we would need to re-think of the placement. I also prefer to fix this issue using fixed positioning rather than undoing the work in T301603: Newcomer tasks: increased flexibility at post-edit dialog and showing it on top of the drawer. Once we resolve T294835: Positive reinforcement: Revise skeleton state and behaviour of the Post-edit dialog, the render of the drawer won't depend on any data request so both message and drawer will appear immediately after save.

What do you think about the fixed positioning @RHo?

In T317819#8630608, @Sgs wrote:

In T317819#8617279, @Tgr wrote:

FWIW the old behavior was added in T301603: Newcomer tasks: increased flexibility at post-edit dialog, on the basis that it is more engaging/noticeable. I wouldn't mind getting rid of it (IMO it was one of those UX flourishes where the improvement wasn't really proportional with the code complexity it required), but we could probably fix it just by changing the positioning from absolute to fixed.

I agree. Tying the apparition of the message to the apparition of the drawer in both positioning and timing seems conceptually incorrect because the message is the feedback from a successful save. If the drawer breaks for any reason we would probably fail to show an edit success message which seems critical for a newcomer. Also if we wanted to stop showing the post edit drawer for any reason we would need to re-think of the placement. I also prefer to fix this issue using fixed positioning rather than undoing the work in T301603: Newcomer tasks: increased flexibility at post-edit dialog and showing it on top of the drawer. Once we resolve T294835: Positive reinforcement: Revise skeleton state and behaviour of the Post-edit dialog, the render of the drawer won't depend on any data request so both message and drawer will appear immediately after save.

What do you think about the fixed positioning @RHo?

Sounds good, IIRC think we had it at the top on Desktop to match VE save messages only, but I do prefer this behaviour as consistent with the mobile placement and connection to the post-edit dialog drawer. And to confirm, let' use the same distance of 1em between the drawer and the success message. Thanks!

Change 891411 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Post-edit: Use fixed positioning for success notice

https://gerrit.wikimedia.org/r/891411

Change 888763 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] Post edit: show the success toast message tied to the drawer

Reason:

Abandoned in favor of fixed positioning in I2c6f2ce3cc65c77a6147ed4fb1438966d4e5d02c per review comments

https://gerrit.wikimedia.org/r/888763

Change 891411 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post-edit: Use fixed positioning for success notice

https://gerrit.wikimedia.org/r/891411

We opted to go for a fixed positioning on desktop; even if that makes the behavior slightly different from mobile not having the success message tied to the drawer in time and positioning gives us flexibility now that other panels are appearing after save. Also tying the toast to the drawer means if the code for showing the drawer breaks we could end up not informing the user about the successfully saved edit. Hope this is good enough for solving the issue.

Checked in enwiki betalabs and testwiki wmf.25 - works as expected.
{F36885025}