Page MenuHomePhabricator

Revert custom override for the default QuickSurvey i18n after survey is done
Closed, ResolvedPublic

Description

For the survey we created an override to the default i18n message on the button to visit the external survey. This should be reverted when the survey is done.

ext-quicksurveys-external-survey-yes-button on (https://de.wikipedia.org/wiki/MediaWiki:ext-quicksurveys-external-survey-yes-button) needs to be reset.

Event Timeline

Shall we also follow up by making more of these labels configurable? The code change is a bit annoying since the quasi-schema fields needs to be threaded through SurveyFactory, but at the point of usage the concept is simple, for example this is an already configurable label:

thankYouMessage: mw.msg( survey.confirmMsg || 'ext-quicksurveys-survey-confirm-msg' ),

Shall we also follow up by making more of these labels configurable? The code change is a bit annoying since the quasi-schema fields needs to be threaded through SurveyFactory, but at the point of usage the concept is simple, for example this is an already configurable label:

thankYouMessage: mw.msg( survey.confirmMsg || 'ext-quicksurveys-survey-confirm-msg' ),

Sure, let's do that!