Page MenuHomePhabricator

Simplify QuickSurveys configuration by enabling everywhere
Closed, ResolvedPublic

Description

Since the optimization work in T213459, there's very little performance penalty when enabling QuickSurveys on a wiki. Server-side guard conditions will prevent ResourceLoader modules from loading when no surveys are configured for the wiki. I propose that we now enable Quicksurveys everywhere.

This removes a possible source of confusion when deploying new surveys.

Event Timeline

Change 832393 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] [WIP] Enable QuickSurveys on all wikis

https://gerrit.wikimedia.org/r/832393

Is there anything that I can do to help?

Is there anything that I can do to help?

Thanks! If you think the WIP patch makes sense, we can try deploying...

Jdlrobson-WMF subscribed.

Enabling it everywhere makes sense to me. Kinda weird that it isn't.

I now remember why it's not enabled everywhere. The logic for display logic only works on article namespace would likely not be compatible with projects like Wikidata.org and Wikisource.

Jdlrobson-WMF moved this task from Config to Next on the QuickSurveys board.

Change #1194309 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable QuickSurveys on all wikis

https://gerrit.wikimedia.org/r/1194309

Change #1194309 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable QuickSurveys on all wikis

https://gerrit.wikimedia.org/r/1194309

Mentioned in SAL (#wikimedia-operations) [2025-10-22T22:20:26Z] <jdlrobson@deploy2002> Started scap sync-world: Backport for [[gerrit:1194309|Enable QuickSurveys on all wikis (T317841)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-22T22:24:39Z] <jdlrobson@deploy2002> jdlrobson: Backport for [[gerrit:1194309|Enable QuickSurveys on all wikis (T317841)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-22T22:30:38Z] <jdlrobson@deploy2002> Finished scap sync-world: Backport for [[gerrit:1194309|Enable QuickSurveys on all wikis (T317841)]] (duration: 10m 12s)