Page MenuHomePhabricator

Update override of IndexPager::makeLink to instead override PagerNavigationBuilder::makeLink
Closed, ResolvedPublic

Description

See parent task for more detailed description.

Uses and overrides of IndexPager::makeLink are being deprecated and instead PagerNavigationBuilder::makeLink should be overridden through a class that extends the builder and is then returned when calling IndexPager::getNavigationBar

Override to address:

  • CNBannerPager::makeLink

Event Timeline

Dreamy_Jazz changed the subtype of this task from "Feature Request" to "Task".Sep 22 2022, 11:34 PM

Change 875451 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralNotice@master] Avoid deprecated override for IndexPager::makeLink

https://gerrit.wikimedia.org/r/875451

Note that CN gets deployed differently than rest of extensions. It doesn't follow the train.

Change 875451 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Avoid deprecated override for IndexPager::makeLink

https://gerrit.wikimedia.org/r/875451

matmarex claimed this task.