| Jdlrobson | |
| Sep 15 2022, 10:58 PM |
| F35535684: Screen Shot 2022-09-26 at 6.15.53 PM.png | |
| Sep 27 2022, 1:16 AM |
| F35535683: Screen Shot 2022-09-26 at 6.16.08 PM.png | |
| Sep 27 2022, 1:16 AM |
| F35527605: Screen Shot 2022-09-21 at 3.57.36 PM.png | |
| Sep 21 2022, 10:57 PM |
| F35521793: Screen Shot 2022-09-15 at 3.58.01 PM.png | |
| Sep 15 2022, 10:58 PM |
| F35521792: Screen Shot 2022-09-15 at 3.57.56 PM.png | |
| Sep 15 2022, 10:58 PM |
https://en.wikipedia.org/wiki/Special:Preferences
https://en.wikipedia.org/wiki/Main_Page
The toolbar on both pages despite empty has a border.
This appears to be because of
.mw-article-toolbar-container having border-bottom 1px solid #C8CCD1
.vector-page-titlebar also has a border so these become combined on special pages
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T317930#8262902 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix border when title is hidden and when toolbar is empty | mediawiki/skins/Vector | master | +12 -4 |
@Jdlrobson Likely introduced by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/817306 (T313947). The border for the page titlebar was previously applied to the h1, and after that patch it was moved to the container.
Reverting might make sense for a quick fix, or if possible moving the "display: none" style from the h1 to .vector-page-titlebar
I think there's actually two issues here, one is the border on the main page (which is related to T313947), and the second is the border on Special pages when the page toolbar is empty. This second issue was preexisting, and due to this selector being removed at some point.
@Jdlrobson What do you think of something like this https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/833078 to fix the first case of the main page?
Change 833078 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] POC: Fix border on main page when title is hidden
Change 833078 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix border when title is hidden and when toolbar is empty
@Jdlrobson I want to be certain what I'm validating. I assume the line under preferences below (copied from description) should appear sharper.
But I'm not sure what I'm validating here
@Edtadros both of those are incorrect. Check the beta cluster versions of those pages e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences to see what they should look like:
Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Double border does not appear on pages with empty toolbar
