Page MenuHomePhabricator

add on-wiki edits of toolforge tools to toolstats report
Closed, ResolvedPublic

Event Timeline

Change 832620 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[operations/puppet@production] toolforge: add on-wiki edits of toolforge tools to toolsview

https://gerrit.wikimedia.org/r/832620

Change 832620 abandoned by Raymond Ndibe:

[operations/puppet@production] toolforge: add on-wiki edits of toolforge tools to toolsview

Reason:

moving change to gitlab

https://gerrit.wikimedia.org/r/832620

dcaro triaged this task as High priority.EditedJan 24 2024, 4:42 PM
dcaro subscribed.

I think this might need some detail about the design of the solution, @Raymond_Ndibe can you please add what you had in mind?

(essentially, so others can pick it up)

@Raymond_Ndibe: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on October 11th.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

bd808 added subscribers: Andrew, bd808.

A Toolforge job for this task was enabled which seemed to do nothing except crash and spam my mailbox. @Andrew disabled the job.

A Toolforge job for this task was enabled which seemed to do nothing except crash and spam my mailbox. @Andrew disabled the job.

I was actively working on this just an hour ago @bd808 . Thanks for bringing it to my attention. I think it failed once again when it wasn't supposed to. I've git fetched the latest changes to the bastion and enabled it again. Should no longer fail

I was actively working on this just an hour ago @bd808 . Thanks for bringing it to my attention. I think it failed once again when it wasn't supposed to. I've git fetched the latest changes to the bastion and enabled it again. Should no longer fail

Can I assume this task and related MRs are a formal notice that the WMCS team owns the tool and does not need my help in maintaining it?

I was actively working on this just an hour ago @bd808 . Thanks for bringing it to my attention. I think it failed once again when it wasn't supposed to. I've git fetched the latest changes to the bastion and enabled it again. Should no longer fail

Can I assume this task and related MRs are a formal notice that the WMCS team owns the tool and does not need my help in maintaining it?

I'd say that you can interpret this as willingness to help with it :), unless you want to officially drop the maintainership of the tool, then we will have to think and decide if the WMCS team has the resources and wants to take ownership (we are a bit extra tight on resources right now though).

I was actively working on this just an hour ago @bd808 . Thanks for bringing it to my attention. I think it failed once again when it wasn't supposed to. I've git fetched the latest changes to the bastion and enabled it again. Should no longer fail

Can I assume this task and related MRs are a formal notice that the WMCS team owns the tool and does not need my help in maintaining it?

Not necessarily. I think that is a decision we haven't yet made. I personally don't mind us taking it over. The purpose of this PR though is to get this task done and closed.

Not necessarily. I think that is a decision we haven't yet made. I personally don't mind us taking it over. The purpose of this PR though is to get this task done and closed.

I asked because adding new features to store data that has nothing to do with page views and refactoring all of the code in "my" tool feels like a hostile takeover. Maybe y'all talked this through in 2022 without me and decided it would be fine? I'm just honestly trying to figure out if I am on the hook for fixing the tool going forward or not.

Not necessarily. I think that is a decision we haven't yet made. I personally don't mind us taking it over. The purpose of this PR though is to get this task done and closed.

I asked because adding new features to store data that has nothing to do with page views and refactoring all of the code in "my" tool feels like a hostile takeover. Maybe y'all talked this through in 2022 without me and decided it would be fine? I'm just honestly trying to figure out if I am on the hook for fixing the tool going forward or not.

I think it's my fault to assume that you were onboard with this. This task has been open for some time now that the details is now a bit fuzzy. For reference here is the discussion that led to this whole thing https://gerrit.wikimedia.org/r/c/operations/puppet/+/832620/comments/ce28c97a_543fea0d

I will create a new editcounts tool for this and move all the changes there. That's probably a better way around it

@bd808 can you help redeploy the tool using the main branch? while playing with the deployment I had the new branch deployed and that surfaced the the api endpoints. I didn't touch the database tables you created so no permanent damage has been done.

Raymond_Ndibe renamed this task from add on-wiki edits of toolforge tools to toolviews report to add on-wiki edits of toolforge tools to toolstats report.Jan 22 2025, 10:42 AM