Error: Class 'NewsletterDiffEngine' not found
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Zabe
	Sep 16 2022, 2:27 PM

Description

Error

mwversion: 1.40.0-wmf.1
reqId: 12c46b0c-6415-4274-b8e2-92421dea03c9
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Class 'NewsletterDiffEngine' not found

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.1/includes/content/ContentHandler.php(606)
#0 /srv/mediawiki/php-1.40.0-wmf.1/includes/page/Article.php(896): ContentHandler->createDifferenceEngine(RequestContext, integer, string, integer, boolean, boolean)
#1 /srv/mediawiki/php-1.40.0-wmf.1/includes/page/Article.php(465): Article->showDiffPage()
#2 /srv/mediawiki/php-1.40.0-wmf.1/includes/actions/ViewAction.php(78): Article->view()
#3 /srv/mediawiki/php-1.40.0-wmf.1/includes/MediaWiki.php(542): ViewAction->show()
#4 /srv/mediawiki/php-1.40.0-wmf.1/includes/MediaWiki.php(322): MediaWiki->performAction(Article, Title)
#5 /srv/mediawiki/php-1.40.0-wmf.1/includes/MediaWiki.php(904): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.40.0-wmf.1/includes/MediaWiki.php(562): MediaWiki->main()
#7 /srv/mediawiki/php-1.40.0-wmf.1/index.php(50): MediaWiki->run()
#8 /srv/mediawiki/php-1.40.0-wmf.1/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Impact

Notes

Details

MediaWiki Version: 1.40.0-wmf.1
Request URL: https://www.mediawiki.org/w/index.php?diff=*&oldid=*&title=*

	Subject	Repo	Branch	Lines +/-
	Use namespaced class in NewsletterContentHandler::getDiffEngineClass	mediawiki/extensions/Newsletter	REL1_39	+1 -1
	Use namespaced class in NewsletterContentHandler::getDiffEngineClass	mediawiki/extensions/Newsletter	master	+1 -1

Customize query in gerrit

Event Timeline

Zabe created this task.Sep 16 2022, 2:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2022, 2:27 PM

Aklapper added a project: MediaWiki-extensions-Newsletter.Sep 16 2022, 3:20 PM

The error message is without namespace, the extension was namespaced in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Newsletter/+/778363 without aliases, but there is a usage in NewsletterContentHandler::getDiffEngineClass

Change 832708 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Newsletter@master] Use namespaced class in NewsletterContentHandler::getDiffEngineClass

https://gerrit.wikimedia.org/r/832708

gerritbot added a project: Patch-For-Review.Sep 16 2022, 8:58 PM

Change 832708 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Use namespaced class in NewsletterContentHandler::getDiffEngineClass

https://gerrit.wikimedia.org/r/832708

Change 832682 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Newsletter@REL1_39] Use namespaced class in NewsletterContentHandler::getDiffEngineClass

https://gerrit.wikimedia.org/r/832682

Not sure if this needs backporting. It seems the use case to diff a newsletter page is very rare, because the error exists since 1.39-wmf.20 and is visible on, for example, https://www.mediawiki.org/w/index.php?title=Newsletter:The_Community_Tech_Newsletter&diff=2641518&oldid=2622492

Possible easier to just wait a week and let the train fix it

Change 832682 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@REL1_39] Use namespaced class in NewsletterContentHandler::getDiffEngineClass

https://gerrit.wikimedia.org/r/832682

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 16 2022, 11:00 PM

Should be fine to let it ride the train.

Krinkle moved this task from Untriaged to Sep 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:22 PM

Error: Class 'NewsletterDiffEngine' not foundClosed, ResolvedPublicPRODUCTION ERRORActions