Maniphest T318014

Make All Validator Functions True Pass-Throughs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Sep 16 2022, 8:29 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

All validator functions should in theory have the signature

( Z1 ) -> Z1

but some are implemented as

( Z1, Z4 ) -> Z1

This is probably due to historical reasons and/or laziness. We should clean these functions up to see if all validation functions can indeed be made pass-throughs.

Details

	Title	Reference	Author	Source Branch	Dest Branch
	Remove static validation and ensure that all validator functions are pass-throughs.	repos/abstract-wiki/wikifunctions/function-orchestrator!51	apine	apine-no-static-validation	main

Customize query in GitLab

Event Timeline

cmassaro claimed this task.Sep 16 2022, 8:29 PM

cmassaro created this task.

cmassaro added a project: function-orchestrator.

cmassaro updated the task description. (Show Details)

Put in Clean-up by default; if you think this needs to happen sooner, Cory, please go ahead and move it to Current.

Jdforrester-WMF moved this task from Incoming to Blocking launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:28 PM

Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 1:15 AM

Jdforrester-WMF moved this task from Phase κ – Clean-up to Phase λ – Launch on the Abstract Wikipedia team board.Jun 14 2023, 2:03 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.

cmassaro removed cmassaro as the assignee of this task.Jun 28 2023, 6:49 PM

Jdforrester-WMF moved this task from Phase λ – Launch to To triage: After launch on the Abstract Wikipedia team board.Jul 20 2023, 4:57 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase λ – Launch).

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/51

Remove static validation and ensure that all validator functions are pass-throughs.

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/51

Remove static validation and ensure that all validator functions are pass-throughs.

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2023, 2:11 PM

cmassaro claimed this task.Jul 24 2023, 3:40 PM

cmassaro moved this task from To triage: After launch to Phase λ – Launch on the Abstract Wikipedia team board.

cmassaro edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team.

cmassaro moved this task from Engineering tasks to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.

DVrandecic closed this task as Resolved.Jul 25 2023, 3:04 AM