Page MenuHomePhabricator

editnotice interferes with "edit here" in Android app
Closed, ResolvedPublicBUG REPORT

Description

  1. go to [[Prince Harry, Duke of Sussex]] on en in Wikipedia app
  2. select anything, e.g. "David" and choose "edit here"
  3. whether or not you have checked "show edit notices automatically" (which is the default. and even after dismissing popup with X in corner) never takes me to "David" in source

2.7.50420-beta-2022-09-12
device lang en-US
Android 10

Event Timeline

ABorbaWMF added a subscriber: ABorbaWMF.

Tested on 2.7.50421-beta-2022-10-03

Using the above steps, I was able to see the 'highlighted' text on the edit view, but I had to scroll to that point. I'm not sure if this is a new ticket.

Highlighted text

Screenshot_20221006-134536.png (2×1 px, 976 KB)

Edit Notice

Screenshot_20221006-134552.png (2×1 px, 205 KB)

After closing the notice, view was scrolled down (quite a bit)

Screenshot_20221006-134601.png (2×1 px, 300 KB)

After scrolling up, the highlighted text was visible

Screenshot_20221006-134610.png (2×1 px, 289 KB)

Tested on 2.7.50421-beta-2022-10-03

that's the same version I have now. I see same behavior you describe. also tried on [[Dog]] with the word domesticated. same thing most of time. selected but scrolled to wrong place. occasionally also saw cursor at beginning of first line but still started scrolled to bottom.

is this syntax highlighting I see new? could that be related? maybe the inconsistency I saw is dependent on whether I scroll before highlighting is finished?

Hello @jeremyb-phone, I am not sure of the cause of this. I'll ping @Dbrant on that one.

Bringing this back to refine a bit further. There seems to be a lot of device-specific weirdness when trying to scroll programmatically to a location in an EditText.
The present solution is an improvement, but not a complete fix.

@Dbrant Has @scblr weighed in on the color that was chosen to highlight where the edit here is? This orange follows OOUI?

@Dbrant Has @scblr weighed in on the color that was chosen to highlight where the edit here is? This orange follows OOUI?

This was the color chosen when the whole feature was first built. We can certainly tweak it if @scblr suggests a different one.

@Dbrant Has @scblr weighed in on the color that was chosen to highlight where the edit here is? This orange follows OOUI?

This was the color chosen when the whole feature was first built. We can certainly tweak it if @scblr suggests a different one.

@Dbrant which color group from the theme guidelines are we using?

@Dbrant which color group from the theme guidelines are we using?

@scblr Currently this is using the single color osage for all themes. I see in our color groups there's something called text_highlight_color (color_group_45) but this group doesn't look correct for Dark/Black themes.

@Dbrant osage (color_group_62) for all theme’s is the way to go 👍