This extension needs review (security, performance...), and also adding to our
SVN repository

Though, I'm not sure how 5 "supports" == consensus

(In reply to comment #1)

This extension needs review (security, performance...), and also adding to our
SVN repository

What does this mean exactly?

Though, I'm not sure how 5 "supports" == consensus

What are the rules for consensus on extension installation then?

I'm not sure on the rules for consensus. 5 users out of enwiki's community seems far too small

It means the activation isn't of this extension isn't a simple process. It needs checking that the code is sane, secure and won't kill (though, this isn't always obvious) the wikimedia servers. [2]

For the ease of deployment etc, it needs to be in our SVN repository [1]

[1] http://svn.wikimedia.org/svnroot/mediawiki
[2] http://www.mediawiki.org/wiki/Review_queue

Just gave this extension a quick look (over in its Google code repo, it does need to be in SVN here for WMF deployment). At the very least:

• uses raw $_REQUEST
• Couple of global functions should be in classes -- use the autoloader rather than raw includes
• using $wgParser for hook initialization

The extension part of it seems reasonably sane barring these issues--again, I just looked quickly and this was not an in-depth review. I did not look at the pChart library it uses yet, that could be a whole different story.

Would really want some other work too:

• a sane user interface for editing & previewing chart data and options (this is 2011, not 2001 -- we shouldn't just slap up a tag with CSV input syntax and consider ourselves done)

• linking, alternate text, keyboard selection, accessibility (easier with SVG charts than server-side PNGs, though PNGs with image maps can handle clickable things with some limitations)

• integration of data sets between charts and tables/infoboxes/etc (may need to be future-looking, at Semantic MediaWiki or the partial similar implementations that may end up on Wikipedia in a year or two)

• useful ways to interact with charts such as zooming, hiding/showing columns, switching types (again this is 2011!)

• scalable output (native SVG when available?) -- mobile phones, tablets, and improved in-browser zoom features have already brought scaling to the regular web (not to mention printing!)

• a compatible implementation for mwlib for PDF/print output (static output, scalable or high resolution)

sumanah wrote:

(In reply to comment #3)

It means the activation isn't of this extension isn't a simple process. It
needs checking that the code is sane, secure and won't kill (though, this isn't
always obvious) the wikimedia servers. [2]

For future reference: we have now articulated this process in https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment .

Without addressing the concerns in comment 4 and 5 this will be a de facto WONTFIX.
Jan: Did you forward the comments to the extension authors at http://code.google.com/p/pchart4mw/source/browse/ or to their bugtracker at http://code.google.com/p/pchart4mw/issues/list ?