SpecialEditTags.php on line 440
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Nikerabbit
	Sep 19 2022, 9:55 AM

Description

Error

mwversion: 1.40.0-wmf.1
reqId: a2df7ece-22a0-493f-b61b-b0718dfb603d
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 2 passed to ChangeTagsRevisionList::updateChangeTagsOnAll() must be of the type array, null given, called in /srv/mediawiki/php-1.40.0-wmf.1/includes/specials/SpecialEditTags.php on line 440

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.1/includes/changetags/ChangeTagsRevisionList.php(86)
#0 /srv/mediawiki/php-1.40.0-wmf.1/includes/specials/SpecialEditTags.php(440): ChangeTagsRevisionList->updateChangeTagsOnAll(array, NULL, NULL, string, User)
#1 /srv/mediawiki/php-1.40.0-wmf.1/includes/specials/SpecialEditTags.php(158): SpecialEditTags->submit()
#2 /srv/mediawiki/php-1.40.0-wmf.1/includes/specialpage/SpecialPage.php(701): SpecialEditTags->execute(NULL)
#3 /srv/mediawiki/php-1.40.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1428): SpecialPage->run(NULL)
#4 /srv/mediawiki/php-1.40.0-wmf.1/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#5 /srv/mediawiki/php-1.40.0-wmf.1/includes/MediaWiki.php(904): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.40.0-wmf.1/includes/MediaWiki.php(562): MediaWiki->main()
#7 /srv/mediawiki/php-1.40.0-wmf.1/index.php(50): MediaWiki->run()
#8 /srv/mediawiki/php-1.40.0-wmf.1/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Impact

Notes

Surfaced by T311567: ManualLogEntry::getComment() should always return string.

Reported in https://fi.wikipedia.org/w/index.php?title=Wikipedia:Kahvihuone_(tekniikka)&diff=20792152&oldid=20790507&diffmode=visual

Details

Request URL: https://fi.wikipedia.org/w/index.php?action=submit&title=*

	Subject	Repo	Branch	Lines +/-
	SpecialEditTags: Set default value of wpTagsToRemove to empty array	mediawiki/core	REL1_37	+1 -1
	SpecialEditTags: Set default value of wpTagsToRemove to empty array	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T318040: Decide if we should revert "ManualLogEntry::getComment() should always return string" out of REL1_37 before release
T311567: ManualLogEntry::getComment() should always return string

Event Timeline

Nikerabbit created this task.Sep 19 2022, 9:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2022, 9:55 AM

Change 832976 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialEditTags: Set default value of wpTagsToRemove to empty array

https://gerrit.wikimedia.org/r/832976

gerritbot added a project: Patch-For-Review.Sep 19 2022, 10:30 AM

Aklapper added a project: MediaWiki-Special-pages.Sep 19 2022, 11:07 AM

Change 832976 merged by jenkins-bot:

[mediawiki/core@master] SpecialEditTags: Set default value of wpTagsToRemove to empty array

https://gerrit.wikimedia.org/r/832976

Change 833029 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@REL1_37] SpecialEditTags: Set default value of wpTagsToRemove to empty array

https://gerrit.wikimedia.org/r/833029

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 19 2022, 2:00 PM

Change 833029 merged by jenkins-bot:

[mediawiki/core@REL1_37] SpecialEditTags: Set default value of wpTagsToRemove to empty array

https://gerrit.wikimedia.org/r/833029

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2022, 2:30 PM

ReleaseTaggerBot added a project: MW-1.37-notes.Sep 19 2022, 3:00 PM

This should now be Resolved, given that the relevant code was fixed in master and the backports reverted per T318040: Decide if we should revert "ManualLogEntry::getComment() should always return string" out of REL1_37 before release.

Krinkle moved this task from Untriaged to Sep 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:21 PM

TypeError: Argument 2 passed to ChangeTagsRevisionList::updateChangeTagsOnAll() must be of the type array, null given, called in /srv/mediawiki/php-1.40.0-wmf.1/includes/specials/SpecialEditTags.php on line 440Closed, ResolvedPublicPRODUCTION ERRORActions