@ifried To be precise, I wrote this task to be about the back-end only, noting that the functionality would not be exposed in the UI just yet; the task was also estimated according to those premises. So, I'm not sure if the AC about the interface would really belong here. I think it should be in T318954 instead.

@Daimona

Partially my fault here, I asked for more clarification as the existing ticket didn't give me all the information I required to complete this. But I agree this is additional context, not AC.

@Daimona Yes, this was just meant to be context after a conversation between Michelle and I. Anyway, I have moved the UI-related information to the top of the ticket (General Background) and out of the AC.

Change 839633 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add support for private registrations

https://gerrit.wikimedia.org/r/839633

Change 839633 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add support for private registrations

https://gerrit.wikimedia.org/r/839633

This can be tested together with T319455. For now, the expected behaviour is that private participants do not appear anywhere in the interface, not even if you're an organizer.

A few feedback questions and notes on this:

For Organizers should see some visual indicator of who is a private registrant. We are still determining what is the icon of choice, but it would be something like an eye that is crossed out next to the username of the private registrant.

Currently there is no visual indicator. Is this expected? If so, we should just remove the above text from the description in this ticket.

The parameter will accept any string or number that is passed in, but should throw an error unless a boolean is passed in:

When a participant registers privately, their name is successfully hidden from Special:EventDetails, but still displays in the Event details modal, if logged in as the privately registered user:
vid:

user on the left is the participant who privately registered:

In T318121#8358373, @vaughnwalters wrote:

A few feedback questions and notes on this:

For Organizers should see some visual indicator of who is a private registrant. We are still determining what is the icon of choice, but it would be something like an eye that is crossed out next to the username of the private registrant.

Currently there is no visual indicator. Is this expected? If so, we should just remove the above text from the description in this ticket.

Yes, it is expected. According to T318121#8281598 and following comments, it was included in the task description only as additional context, but it's not part of this task.

The parameter will accept any string or number that is passed in, but should throw an error unless a boolean is passed in:

Yeah, that is T305973. More generally, all parameters lack type validation in JSON. I think it's a very important feature, but it should be fixed in core. For now, I think we can just assume that it's up to clients to make sure that the parameter types match.

When a participant registers privately, their name is successfully hidden from Special:EventDetails, but still displays in the Event details modal, if logged in as the privately registered user:

Ah yes, this is indeed the only exception to "private participants do not appear anywhere in the interface". Currently you can always see your name in the "more details" modal even if you've registered privately. This is different in Special:EventDetails (your name wouldn't appear), but that'll change once T321750 is resolved.

When a participant registers privately, their name is successfully hidden from Special:EventDetails, but still displays in the Event details modal, if logged in as the privately registered user:

Ah yes, this is indeed the only exception to "private participants do not appear anywhere in the interface". Currently you can always see your name in the "more details" modal even if you've registered privately. This is different in Special:EventDetails (your name wouldn't appear), but that'll change once T321750 is resolved.

@Daimona Ah, okay. Then since the privately registered user actually should continue display in the "more details" modal as long as they are the user that is logged in, the bug is that the list in that "more details" modal decreases by one shown participant when a user registers privately. However, this only affects events with less than 10 participants, and only when viewing the "more details" modal logged in as the privately logged in participant. In the following example, when logged in as registered participant V, all three participants should display whether logged in privately or publicly:

If user V registered privately:

If user V registered publicly:

Let me know if this is not covered by another ticket (and if it's worth fixing) and I'll make another ticket and move this ticket on.

Hi @vaughnwalters , this is being resolved as part of T319452