Description

Once the mentee overview is deployed to all wikis we can remove the unused code. In particular MenteeOverview.js. MenteeOverview.less can be kept since it holds styles used on the server rendered markup.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Mentor dashboard: remove uneeded files from the non-Vue mentee overview	mediawiki/extensions/GrowthExperiments	master	+16 -1 K
	Mentor dashboard: merge ext.growthExperiments.MentorDashboard.Vue in MentorDashboard	mediawiki/extensions/GrowthExperiments	master	+134 -211

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T311850 [Epic] FY 2022-23 Growth Maintenance Work
Resolved	KStoller-WMF	T323132 [Epic] Q3 FY 2022-23 Growth Maintenance Work
Resolved	kostajh	T324198 Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint
Resolved	• Tgr	T296443 Create GrowthExperiments newcomer tasks backend architecture diagram
Resolved	kostajh	T310351 Add image: Introduce end-to-end tests
Open	None	T312294 Add image: Create end-to-end test to verify saved content
Resolved	kostajh	T321875 ApiQueryGrowthTasks: Refresh TaskSet cache after query
Resolved	Urbanecm_WMF	T325236 WikiPageConfigLoader: Treat "config page does not exist" as a non-error state
Resolved	Sgs	T318254 MenteeOverview: remove unused client code
Resolved	Umherirrender	T74672 Wrong error message after deleting an article
Declined	None	T140915 Remove curid parameter from history links on watch list and recent changes
Declined	None	T140916 Remove curid parameter from diff links on watch list and recent changes
Resolved	Sgs	T328008 Make usage of Codex design tokens in Vue modules

Event Timeline

Sgs created this task.Sep 21 2022, 4:55 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptSep 21 2022, 4:55 PM

Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Sep 29 2022, 10:00 AM

Change 842422 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [DNM] Mentor dashboard: remove uneeded files from the non-Vue mentee overview

https://gerrit.wikimedia.org/r/842422

gerritbot added a project: Patch-For-Review.Oct 13 2022, 11:13 AM

Sgs changed the task status from Open to In Progress.Oct 27 2022, 7:58 AM

Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Volker_E moved this task from Inbox to Following on the Design-System-Team board.Nov 7 2022, 5:24 PM

kostajh triaged this task as Medium priority.Nov 11 2022, 1:12 PM

Change 856007 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: merge ext.growthExperiments.MentorDashboard.Vue in MentorDashboard

https://gerrit.wikimedia.org/r/856007

Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 15 2022, 10:57 AM

Change 842422 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: remove uneeded files from the non-Vue mentee overview

https://gerrit.wikimedia.org/r/842422

Change 856007 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: merge ext.growthExperiments.MentorDashboard.Vue in MentorDashboard

https://gerrit.wikimedia.org/r/856007

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.12; 2022-11-28); removed MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Nov 15 2022, 2:00 PM

Urbanecm_WMF mentioned this in T323243: MenteeOverview: Mentees with user_registration=NULL are not displayed correctly.Nov 16 2022, 10:40 PM

Sgs moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 18 2022, 10:22 AM

Sgs removed projects: GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard.Jan 18 2023, 12:22 PM

DMburugu edited parent tasks, added: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work, T311850: [Epic] FY 2022-23 Growth Maintenance Work; removed: T300532: Migration of mentee overview to Vue.Jan 18 2023, 12:23 PM

kostajh renamed this task from Document migration from OOUI to Vue and remove unused code to MenteeOverview: Document migration from OOUI to Vue and remove unused code.Jan 23 2023, 5:49 PM

Sgs renamed this task from MenteeOverview: Document migration from OOUI to Vue and remove unused code to MenteeOverview: remove unused client code .Jan 24 2023, 4:44 PM

Sgs updated the task description. (Show Details)

Rephrased the title since documenting a full migration from OOUI library to Codex was out of scope of this issue. The mentee overview cleanup is already done and the extension coding conventions are documented here Coding_conventions#Vue.js.

Thanks @Sgs! LGTM. I added a "Tests (WIP)" heading where we could document our expectations around test coverage, snapshot testing, and anything else relevant.

MenteeOverview: remove unused client code Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

MenteeOverview: remove unused client code
Closed, ResolvedPublic
Actions

Related Objects
Search...