Page MenuHomePhabricator

[EPIC] Deprecate EventLogging::logEvent()
Open, Needs TriagePublic

Description

Once the few remaining legacy EventLogging schemas have been removed the production codebases or migrated to Event Platform schemas, EventLogging::logEvent() will only be used as a proxy for EventLogging::submit(). It should be deprecated in order to narrow the EventLogging PHP API.

TODO

  • Always pass $revId = -1 when calling ::logEvent()
  • Update calls to ::logEvent() with equivalent calls to ::submit()
  • Update ::logEvent() to emit a deprecation notice
  • Remove ::logEvent() after the next MediaWiki release

Notes

  1. There are several ::logEvent() calls with schemas that have been migrated to the Event Platform (see below). They can safely be updated to pass $revId = -1

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 825712 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/CheckUser@master] eventLogger: Use $revId of -1 for SpecialInvestigate

https://gerrit.wikimedia.org/r/825712

Change 835626 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikiEditor@master] Hooks: Use $revId of -1 for ::logEvent() calls

https://gerrit.wikimedia.org/r/835626

Change 835627 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/Echo@master] MWEchoEventLogging: Use $revId of -1 for Echo* schemas

https://gerrit.wikimedia.org/r/835627

Change 825712 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] eventLogger: Use $revId of -1 for SpecialInvestigate

https://gerrit.wikimedia.org/r/825712

Change 835626 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Hooks: Use $revId of -1 for ::logEvent() calls

https://gerrit.wikimedia.org/r/835626

Change 835627 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] MWEchoEventLogging: Use $revId of -1 for Echo* schemas

https://gerrit.wikimedia.org/r/835627