Page MenuHomePhabricator

www.wikipedia.org: prefilling the search box with the "search" URL parameter does not work
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

  • The search input contains "Does-not-exist"

Story:
When www.wikipedia.org is opened, the page should evaluate for the presence of the url query parameter <code>search</code>. If this url query parameter is present, then retrieve its value and profile the search field of www.wikipedia.org with this value.

It also needs to avoid security problems, as it takes user input from a potentially untrusted location (the url address), by applying the proper escaping at the proper places.

Event Timeline

Punith.nyk updated Other Assignee, added: Punith.nyk.
Punith.nyk updated Other Assignee, removed: Punith.nyk.

Change 910462 had a related patch set uploaded (by Punith.nyk; author: Punith.nyk):

[wikimedia/portals@master] Make www.wikipedia.org: prefilling the search box with the "search" URL parameter work

https://gerrit.wikimedia.org/r/910462

TheDJ subscribed.

@Punith.nyk I have update the ticket with a more exact description of the work that is required.

Change 910462 abandoned by Aklapper:

[wikimedia/portals@master] Make www.wikipedia.org: prefilling the search box with the "search" URL parameter work

Reason:

I don't see how it helps anybody ever to prefill their search box with "Does-not-exist". Not sure why this patch was created and proposed?

https://gerrit.wikimedia.org/r/910462

Change 910766 had a related patch set uploaded (by Punith.nyk; author: Punith.nyk):

[wikimedia/portals@master] Make www.wikipedia.org: prefilling the search box with the "search" URL parameter work

https://gerrit.wikimedia.org/r/910766