Page MenuHomePhabricator
Create Task
Maniphest T318293

Add to the ZWrapper code of a Z22 the ability to modify the internals
Closed, ResolvedPublic
Actions

Description

When we're adjusting a Z22's meta-data map, we're down-casting to JSON, modifying, and then re-wrapping in a new ZWrapper, which isn't great.

Details

SubjectRepoBranchLines +/-
Allow metadata values to be set without conversion to/from ZWrapper.mediawiki/services/function-orchestratormaster+21 -9
Update function-schemata sub-module to HEAD (1a5e338)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (1a5e338)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (1a5e338)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (1a5e338)mediawiki/tools/wikilambda-climaster+1 -1
Allow setZMapValue to run a callback over values it sets (allows things like conversion to ZWrapper).mediawiki/services/function-schematamaster+159 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Sep 21 2022, 10:11 PM
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Oct 4 2022, 6:33 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
cmassaro moved this task from Incoming to Ready: G2. Correct & efficient on the Abstract Wikipedia team (Phase θ – Throttling) board.Oct 5 2022, 3:16 PM
cmassaro added a project: good first task.
Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 21 2022, 8:22 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).
cmassaro claimed this task.Jan 30 2023, 12:11 PM
gerritbot added a comment.Jan 30 2023, 4:33 PM

Change 884949 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Allow metadata values to be set without conversion to/from ZWrapper.

https://gerrit.wikimedia.org/r/884949

gerritbot added a project: Patch-For-Review.Jan 30 2023, 4:33 PM

Change 884950 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Allow setZMapValue to run a callback over values it sets (allows things like conversion to ZWrapper).

https://gerrit.wikimedia.org/r/884950

gerritbot added a comment.Feb 1 2023, 12:48 PM

Change 884950 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Allow setZMapValue to run a callback over values it sets (allows things like conversion to ZWrapper).

https://gerrit.wikimedia.org/r/884950

cmassaro mentioned this in rMSFSf2ca8e28ad57: Allow setZMapValue to run a callback over values it sets (allows things like….Feb 1 2023, 12:49 PM
gerritbot added a comment.Feb 1 2023, 1:17 PM

Change 885804 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885804

gerritbot added a comment.Feb 1 2023, 2:26 PM

Change 885821 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885821

gerritbot added a comment.Feb 1 2023, 2:26 PM

Change 885822 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885822

gerritbot added a comment.Feb 1 2023, 2:27 PM

Change 885824 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885824

gerritbot added a comment.Feb 1 2023, 4:22 PM

Change 885804 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885804

cmassaro mentioned this in rMSFO7318627cabf4: Update function-schemata sub-module to HEAD (1a5e338).Feb 1 2023, 4:22 PM
gerritbot added a comment.Feb 1 2023, 4:23 PM

Change 885824 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885824

Jdforrester-WMF mentioned this in rMTWC3bd46f7df18e: Update function-schemata sub-module to HEAD (1a5e338).Feb 1 2023, 4:23 PM
gerritbot added a comment.Feb 1 2023, 4:25 PM

Change 885821 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885821

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 1 2023, 5:00 PM
gerritbot added a comment.Feb 1 2023, 6:33 PM

Change 884949 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Allow metadata values to be set without conversion to/from ZWrapper.

https://gerrit.wikimedia.org/r/884949

cmassaro mentioned this in rMSFOadef2ae13bd6: Allow metadata values to be set without conversion to/from ZWrapper..Feb 1 2023, 6:33 PM
gerritbot added a comment.Feb 2 2023, 2:44 PM

Change 885822 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (1a5e338)

https://gerrit.wikimedia.org/r/885822

Jdforrester-WMF mentioned this in rMSFEfe368c48c6b6: Update function-schemata sub-module to HEAD (1a5e338).Feb 2 2023, 2:45 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 3:29 PM
Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 12:42 AM
cmassaro removed cmassaro as the assignee of this task.May 31 2023, 12:27 PM
cmassaro subscribed.
Mcastro moved this task from To triage: Nice-to-haves to Verify in production on the Abstract Wikipedia team board.Jan 18 2024, 5:47 PM
Jdforrester-WMF closed this task as Resolved.Jan 18 2024, 6:21 PM
Jdforrester-WMF claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL