Page MenuHomePhabricator

[Config Change] Enable all DiscussionTools by default at partner wikis (mobile)
Closed, ResolvedPublic

Description

In T298062, we will run an A/B test on mobile talk pages to evaluate the cumulative impact of all of the DiscussionTools we've built. [i]

This task involves deploying the aforementioned suite of mobile DiscussionTools to the initial mobile partner wikis ahead of the A/B test beginning. This way, we can ensure these features are working in the ways: A) volunteers expect them to and B) we have designed them to.

Deployment Timing

Tuesday 27 Sep 2022

Deployment Wikipedias

  1. Arabic
  2. Bangla
  3. Chinese
  4. French
  5. Haitian Creole
  6. Hebrew
  7. Korean
  8. Vietnamese

Requirements

  • People who meet the criteria below will see the Reply Tool, New Topic Tool, Topic Subscriptions, and Usability Improvements (Topic Containers, Clear Affordances, and Page Frame) when visiting any Article or User talk pages:
    • People using the Minerva Neue skin
    • People accessing any of the wikis listed in the Deployment Wikipedias section above

Minimum test case

  1. At one of the wikis listed in Deployment Wikipedias above, visit an article or user talk page
  2. Topic Containers
    • Verify that all section headings are styled and contain the metadata we defined in T311612 and T310914, respectively
    • Verify that all sections that do NOT contain signed comments do NOT contain any metadata
    • Verify that the metadata contained within each Topic Container is accurate
  3. Clear Affordances:
    • Verify that Reply buttons appear next to each signed comment
    • Verify that Reply buttons are styled in the way we defined in T309904.
      • Read Reply buttons ought to appear on the line beneath the comment to which they are related and be preceded by an arrow [in LTR languages].
  4. Reply Tool:
    • Verify that upon tapping any Reply button the Reply Tool opens
  5. New Topic Tool:
    • Verify that upon tapping the Add topic button that appears at the top of the talk page (the location of this button will change in T316175), the New Topic Tool opens
  6. Topic Subscriptions:
    • Verify that 🔔 Subscribe affordances appear within each Topic Container as defined in F35267400/T310914
    • Verify that you receive a notification when a new comment is posted in a topic you subscribed to using mobile talk pages
    • Verify that you do NOT receive a notification when a new comment is posted in a topic you unsubscribed from
  7. Page Frame:
    • Verify that at the top of the talk page, beneath the page toolbar, you see and can use the latest comment indicator in the ways we defined in T306675.

Done

  • Requirements are implemented and verified as having been implemented

i. Reply Tool, New Topic Tool, Topic Subscriptions, and Usability Improvements (Topic Containers, Clear Affordances, and Page Frame)

Related Objects

Event Timeline

Amusingly, I went to write the patch for this and it was all already done in T298221. These wikis (plus Japanese) have had mobile DT enabled by default since the end of June.

Change 835697 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Visual enhancement features are now part of the mobile set

https://gerrit.wikimedia.org/r/835697

Tragically, I was wrong. They've had the config applied, but this task is really more changing the meaning of the config.

I noticed that Japanese Wikipedia is missing from the list here, but it was included in T318302. Is this intentional? I hope not, because if it is, we'll need some special configuration for it.

Change 835697 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Visual enhancement features are now part of the mobile set

https://gerrit.wikimedia.org/r/835697

DLynch added a project: Editing QA.

QA note: you can test the addition of the features on any beta site that's not the english beta site. They'll appear on the scheduled wikis in next week's deployment. I'll note here if I wind up backporting the patch to speed that up.

I noticed that Japanese Wikipedia is missing from the list here, but it was included in T318302. Is this intentional? I hope not, because if it is, we'll need some special configuration for it.

Good spot, @matmarex

Summarizing yesterday...

We decided to continue with the plan to exclude ja.wiki from this deployment. Doing so was made possible by T318871 which will be removed in T318868 before T318870 happens.

Hi, I had a quick look at w:fr. I saw the “[ reply ], “latest comment” and “🔔 subscribe” affordances in the mobile talk overlay but not in the mobile “read as wiki page” view. Is that intentional?

@Pelagic That's correct! (Though there's not really an "overlay" any more.) I think we decided to persist the previous mobile behavior of "read as wiki page" meaning to view it without any sort of tool assistance. It's arguably confusing now, I'll admit.

EAkinloose subscribed.

Tested on frwiki

✅ Topic Containers
✅ Clear Affordances

IMG_8835.PNG (2×1 px, 460 KB)

IMG_8834.jpg (2×1 px, 654 KB)

IMG_8836.jpg (2×1 px, 667 KB)

IMG_C4B39A4A0807-1.jpeg (2×1 px, 682 KB)

✅ Reply Tool:

IMG_8838.PNG (2×1 px, 456 KB)

✅ New Topic Tool:

IMG_8837.PNG (2×1 px, 430 KB)

✅ Topic Subscriptions:

Screenshot 2022-10-11 at 17.19.42.png (226×956 px, 34 KB)

IMG_85F4DF0957F6-1.jpeg (2×1 px, 807 KB)

✅ Page Frame:

IMG_CCA79F33B8A7-1.jpeg (2×1 px, 727 KB)