Page MenuHomePhabricator

Function editor: Implement "remove input field" button for Desktop view
Closed, ResolvedPublic

Description

Please read description of parent task for more details T318314

Once we have the functionality of deleting an input field T318315 and the designs for desktop T318316 we will implement this feature in Desktop

Related Objects

Event Timeline

Also as part of this, we should allow for the deletion of the first argument since we allow no argument functions. Currently (on mobile), only deletion of the second+ argument is possible.

Change 857058 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Enable deleting arguments on desktop (mobile already implemented). Enable deleting the first argument on both mobile and desktop.

https://gerrit.wikimedia.org/r/857058

Change 857058 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Enable deleting arguments on desktop (mobile already implemented). Enable deleting the first argument on both mobile and desktop.

https://gerrit.wikimedia.org/r/857058

Change 860593 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Remove red color from trash icon, as per swoodruff-ctr@wikimedia.org

https://gerrit.wikimedia.org/r/860593

Per @SWoodruff-WMF - we should remove the red color from the icon, elsewhere it denotes an error state

Change 860593 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionDefinitionInputsItem: Remove red 'destructive' color from trash icon

https://gerrit.wikimedia.org/r/860593