Page MenuHomePhabricator
Create Task
Maniphest T318317

Function editor: Implement "remove input field" button for Desktop view
Closed, ResolvedPublic
Actions

Description

Please read description of parent task for more details T318314

Once we have the functionality of deleting an input field T318315 and the designs for desktop T318316 we will implement this feature in Desktop

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FunctionDefinitionInputsItem: Remove red 'destructive' color from trash iconmediawiki/extensions/WikiLambdamaster+0 -2
Enable deleting arguments on desktop (mobile already implemented). Enable deleting the first argument on both mobile and desktop.mediawiki/extensions/WikiLambdamaster+94 -36
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Sep 22 2022, 10:04 AM
gengh mentioned this in T318314: Function editor: Remove an item from the list of arguments.
gengh moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Oct 5 2022, 1:14 PM
gengh added a parent task: T318933: CUJ 3: Edit a function definition.Oct 5 2022, 1:39 PM
Ddwaal claimed this task.Nov 16 2022, 4:39 PM
Ddwaal added a comment.Nov 16 2022, 5:11 PM

Also as part of this, we should allow for the deletion of the first argument since we allow no argument functions. Currently (on mobile), only deletion of the second+ argument is possible.

gerritbot added a comment.Nov 16 2022, 7:53 PM

Change 857058 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Enable deleting arguments on desktop (mobile already implemented). Enable deleting the first argument on both mobile and desktop.

https://gerrit.wikimedia.org/r/857058

gerritbot added a project: Patch-For-Review.Nov 16 2022, 7:53 PM
gerritbot added a comment.Nov 23 2022, 5:47 PM

Change 857058 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Enable deleting arguments on desktop (mobile already implemented). Enable deleting the first argument on both mobile and desktop.

https://gerrit.wikimedia.org/r/857058

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 23 2022, 6:01 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 23 2022, 6:30 PM
gerritbot added a comment.Nov 28 2022, 7:06 PM

Change 860593 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Remove red color from trash icon, as per swoodruff-ctr@wikimedia.org

https://gerrit.wikimedia.org/r/860593

gerritbot added a project: Patch-For-Review.Nov 28 2022, 7:06 PM
• JKieserman added subscribers: • SWoodruff-WMF, • JKieserman.Nov 28 2022, 7:19 PM

Per @SWoodruff-WMF - we should remove the red color from the icon, elsewhere it denotes an error state

gerritbot added a comment.Dec 20 2022, 10:33 AM

Change 860593 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionDefinitionInputsItem: Remove red 'destructive' color from trash icon

https://gerrit.wikimedia.org/r/860593

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Dec 20 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 20 2022, 11:30 AM
Ddwaal moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Dec 20 2022, 11:34 AM
DVrandecic closed this task as Resolved.Dec 21 2022, 3:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits